Skip to content

Increase the announcement period in liveliness test#5952

Merged
rsanchez15 merged 1 commit into2.14.xfrom
hotfix/liveliness-test
Jul 24, 2025
Merged

Increase the announcement period in liveliness test#5952
rsanchez15 merged 1 commit into2.14.xfrom
hotfix/liveliness-test

Conversation

@rsanchez15
Copy link
Copy Markdown
Contributor

@rsanchez15 rsanchez15 commented Jul 23, 2025

Description

This PR increase the announcement period in liveliness QoS test.

Failing test output:

2025-07-22T12:12:18.4389161Z             Start   702: BlackboxTests_DDS_PIM.LivelinessQos/LivelinessQos.IndependentTopics_reliable/Transport
2025-07-22T12:12:18.4389564Z 
2025-07-22T12:12:18.4391059Z 702: Test command: D:\a\Fast-DDS\Fast-DDS\build\fastrtps\test\blackbox\RelWithDebInfo\BlackboxTests_DDS_PIM.exe "--gtest_filter=LivelinessQos/LivelinessQos.IndependentTopics_reliable/Transport" "--gtest_also_run_disabled_tests"
2025-07-22T12:12:18.4392445Z 702: Environment variables: 
2025-07-22T12:12:18.4392881Z 702:  CERTS_PATH=D:/a/Fast-DDS/Fast-DDS/src/fastrtps/test/certs
2025-07-22T12:12:18.4394248Z 702:  TOPIC_RANDOM_NUMBER=4096
2025-07-22T12:12:18.4395676Z 702:  W_UNICAST_PORT_RANDOM_NUMBER=5755
2025-07-22T12:12:18.4396933Z 702:  R_UNICAST_PORT_RANDOM_NUMBER=5756
2025-07-22T12:12:18.4397868Z 702:  MULTICAST_PORT_RANDOM_NUMBER=5757
2025-07-22T12:12:18.4398893Z 702: Test timeout computed to be: 300
2025-07-22T12:12:18.5589662Z 702: Note: Google Test filter = LivelinessQos/LivelinessQos.IndependentTopics_reliable/Transport
2025-07-22T12:12:18.5590404Z 702: [==========] Running 1 test from 1 test suite.
2025-07-22T12:12:18.5590894Z 702: [----------] Global test environment set-up.
2025-07-22T12:12:18.5592377Z 702: Generating port 7264
2025-07-22T12:12:18.5593704Z 702: [----------] 1 test from LivelinessQos/LivelinessQos
2025-07-22T12:12:18.5595255Z 702: [ RUN      ] LivelinessQos/LivelinessQos.IndependentTopics_reliable/Transport
2025-07-22T12:12:18.5861190Z 702: Created datareader 01.0f.71.bb.d8.08.c4.38.00.00.00.00|0.0.1.4 for topic LivelinessQos/LivelinessQos_IndependentTopics_reliable/Transport1_runnervm51nrn_2264
2025-07-22T12:12:18.6283216Z 702: Created datareader 01.0f.71.bb.d8.08.c4.38.01.00.00.00|0.0.1.4 for topic LivelinessQos/LivelinessQos_IndependentTopics_reliable/Transport2_runnervm51nrn_2264
2025-07-22T12:12:18.6546215Z 702: Created datawriter 01.0f.71.bb.d8.08.c4.38.02.00.00.00|0.0.1.3 for topic LivelinessQos/LivelinessQos_IndependentTopics_reliable/Transport1_runnervm51nrn_2264
2025-07-22T12:12:18.6707581Z 702: Created datawriter 01.0f.71.bb.d8.08.c4.38.03.00.00.00|0.0.1.3 for topic LivelinessQos/LivelinessQos_IndependentTopics_reliable/Transport2_runnervm51nrn_2264
2025-07-22T12:12:18.6708682Z 702: Reader is waiting discovery...
2025-07-22T12:12:18.7939265Z 702: Subscriber matched publisher 1.f.71.bb.d8.8.c4.38.2.0.0.0.0.0.1.3
2025-07-22T12:12:18.7939864Z 702: Reader discovery finished...
2025-07-22T12:12:18.7940924Z 702: Reader is waiting discovery...
2025-07-22T12:12:18.8248514Z 702: Subscriber matched publisher 1.f.71.bb.d8.8.c4.38.3.0.0.0.0.0.1.3
2025-07-22T12:12:18.8249188Z 702: Reader discovery finished...
2025-07-22T12:12:18.8250673Z 702: Writer is waiting discovery...
2025-07-22T12:12:18.9042958Z 702: Publisher matched subscriber 1.f.71.bb.d8.8.c4.38.0.0.0.0.0.0.1.4
2025-07-22T12:12:18.9043502Z 702: Writer discovery finished...
2025-07-22T12:12:18.9044733Z 702: Writer is waiting discovery...
2025-07-22T12:12:18.9357948Z 702: Publisher matched subscriber 1.f.71.bb.d8.8.c4.38.1.0.0.0.0.0.1.4
2025-07-22T12:12:18.9359043Z 702: Writer discovery finished...
2025-07-22T12:12:18.9360503Z 702: Sent HelloWorld 0
2025-07-22T12:12:18.9362595Z 702: D:\a\Fast-DDS\Fast-DDS\src\fastrtps\test\blackbox\common\BlackboxTestsLivelinessQos.cpp(2110): error: Expected equality of these values:
2025-07-22T12:12:18.9363339Z 702:   liveliness.alive_count
2025-07-22T12:12:18.9364562Z 702:     Which is: 1
2025-07-22T12:12:18.9365649Z 702:   0
2025-07-22T12:12:18.9366737Z 702: Sent HelloWorld 0
2025-07-22T12:12:18.9368178Z 702: Subscriber unmatched publisher 1.f.71.bb.d8.8.c4.38.3.0.0.0.0.0.1.3
2025-07-22T12:12:20.9638709Z 702: Created datawriter 01.0f.71.bb.d8.08.c4.38.03.00.01.00|0.0.1.3 for topic LivelinessQos/LivelinessQos_IndependentTopics_reliable/Transport2_runnervm51nrn_2264
2025-07-22T12:12:20.9639485Z 702: Reader is waiting discovery...
2025-07-22T12:12:22.2670785Z 702: Subscriber matched publisher 1.f.71.bb.d8.8.c4.38.3.0.1.0.0.0.1.3
2025-07-22T12:12:22.2671775Z 702: Reader discovery finished...
2025-07-22T12:12:22.2672142Z 702: Sent HelloWorld 0
2025-07-22T12:12:22.3771886Z 702: Publisher matched subscriber 1.f.71.bb.d8.8.c4.38.1.0.0.0.0.0.1.4
2025-07-22T12:12:22.4857491Z 702: Subscriber unmatched publisher 1.f.71.bb.d8.8.c4.38.2.0.0.0.0.0.1.3
2025-07-22T12:12:24.4910619Z 702: Subscriber unmatched publisher 1.f.71.bb.d8.8.c4.38.3.0.1.0.0.0.1.3
2025-07-22T12:12:26.5175505Z 702: [  FAILED  ] LivelinessQos/LivelinessQos.IndependentTopics_reliable/Transport, where GetParam() = 0 (7958 ms)
2025-07-22T12:12:26.5176630Z [Processing: fastrtps]
2025-07-22T12:12:26.5177142Z 702: [----------] 1 test from LivelinessQos/LivelinessQos (7958 ms total)
2025-07-22T12:12:26.5178142Z 702: 
2025-07-22T12:12:26.5178525Z 702: [----------] Global test environment tear-down
2025-07-22T12:12:26.5179531Z 702: [==========] 1 test from 1 test suite ran. (7958 ms total)
2025-07-22T12:12:26.5180108Z 702: [  PASSED  ] 0 tests.
2025-07-22T12:12:26.5181714Z 702: [  FAILED  ] 1 test, listed below:
2025-07-22T12:12:26.5183471Z 702: [  FAILED  ] LivelinessQos/LivelinessQos.IndependentTopics_reliable/Transport, where GetParam() = 0
2025-07-22T12:12:26.5184830Z 702: 
2025-07-22T12:12:26.5185724Z 702:  1 FAILED TEST
2025-07-22T12:12:26.6372504Z           Test   #702: BlackboxTests_DDS_PIM.LivelinessQos/LivelinessQos.IndependentTopics_reliable/Transport ....................................................................................................................................................................................................................................................................***Failed    8.20 sec

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Raúl <raul@eprosima.com>
@rsanchez15 rsanchez15 requested a review from cferreiragonz July 23, 2025 10:55
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 23, 2025
@rsanchez15 rsanchez15 added this to the v2.14.5 milestone Jul 23, 2025
@cferreiragonz cferreiragonz changed the title Increate the announcement period in liveliness test Increase the announcement period in liveliness test Jul 23, 2025
@rsanchez15 rsanchez15 merged commit 9d5cf76 into 2.14.x Jul 24, 2025
19 checks passed
@rsanchez15 rsanchez15 deleted the hotfix/liveliness-test branch July 24, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants