Skip to content

[23085] Remove deprecated windows 2019 from ci in favor of 2022#5949

Merged
MiguelCompany merged 2 commits into2.6.xfrom
ci/windows-2022
Jul 23, 2025
Merged

[23085] Remove deprecated windows 2019 from ci in favor of 2022#5949
MiguelCompany merged 2 commits into2.6.xfrom
ci/windows-2022

Conversation

@Mario-DL
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL commented Jul 23, 2025

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v2.6.11 milestone Jul 23, 2025
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@MiguelCompany MiguelCompany self-requested a review July 23, 2025 06:26
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 23, 2025
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green Windows CI

Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to upgrade the version of CMake used in the workflow

@Mario-DL Mario-DL requested review from MiguelCompany and removed request for MiguelCompany July 23, 2025 06:41
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested review from MiguelCompany and removed request for MiguelCompany July 23, 2025 07:11
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green Windows CI

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 23, 2025
@MiguelCompany MiguelCompany merged commit da55c54 into 2.6.x Jul 23, 2025
5 of 17 checks passed
@MiguelCompany MiguelCompany deleted the ci/windows-2022 branch July 23, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants