Skip to content

Use WINDOWS 2022 in CI#5909

Merged
MiguelCompany merged 3 commits into2.14.xfrom
fix_windows_ci_2_14_x
Jul 2, 2025
Merged

Use WINDOWS 2022 in CI#5909
MiguelCompany merged 3 commits into2.14.xfrom
fix_windows_ci_2_14_x

Conversation

@EugenioCollado
Copy link
Copy Markdown
Contributor

@EugenioCollado EugenioCollado commented Jul 1, 2025

Description

Use WINDOWS 2022 as platform for CI testing instead of the current 2019 not supported version

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NA Any new/modified methods have been properly documented using Doxygen.
  • NA Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • NA New feature has been added to the versions.md file (if applicable).
  • NA New feature has been documented/Current behavior is correctly described in the documentation.
  • NA Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EugenioCollado EugenioCollado changed the base branch from master to 2.14.x July 1, 2025 07:34
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado force-pushed the fix_windows_ci_2_14_x branch from 4b2ba7e to b05eddb Compare July 1, 2025 07:35
@EugenioCollado EugenioCollado added this to the v2.14.5 milestone Jul 1, 2025
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Jul 1, 2025
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima July 1, 2025 08:04
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado mentioned this pull request Jul 1, 2025
13 tasks
@EugenioCollado
Copy link
Copy Markdown
Contributor Author

After merge, it is required to update the CI requirements to remove the v141 and add v143 @rsanchez15

@rsanchez15 rsanchez15 self-requested a review July 1, 2025 10:43
@MiguelCompany MiguelCompany merged commit 898ee97 into 2.14.x Jul 2, 2025
17 of 19 checks passed
@MiguelCompany MiguelCompany deleted the fix_windows_ci_2_14_x branch July 2, 2025 05:49
@mergify mergify bot mentioned this pull request Jul 2, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants