Skip to content

[23128] Support builtin annotations in IDL Parser#5908

Merged
MiguelCompany merged 34 commits intomasterfrom
feature/idl-parser-builtin-annotations
Jul 29, 2025
Merged

[23128] Support builtin annotations in IDL Parser#5908
MiguelCompany merged 34 commits intomasterfrom
feature/idl-parser-builtin-annotations

Conversation

@Carlosespicur
Copy link
Copy Markdown
Contributor

@Carlosespicur Carlosespicur commented Jun 30, 2025

Description

This PR add support for builtin annotations in IDL Parser:

  • Adds Annotation class, which provides an interface to simplify the annotations parsing.
  • Adds a method AnnotationsList::from_builtin(), that defines each supported builtin annotation
  • Fixes Cleanup guards for error handling
  • Adds a IDLParserUtils file, for generic std::string transformations
  • Add a IDLParserTags file to avoid hardcoding annotations values and names
  • Extend MemberDescriptor with position(), literal_value() and is_default_literal() methods to avoid inconsistencies annotating enumerations and bitmask members.
  • Extend TypeDescriptor with literal_type to store the literal type in enumerations.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR:
  • NO Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Carlosespicur Carlosespicur added this to the v3.3.0 milestone Jun 30, 2025
@Carlosespicur Carlosespicur force-pushed the feature/idl-parser-builtin-annotations branch 7 times, most recently from 71ea547 to 7c8a32c Compare July 4, 2025 07:10
@Carlosespicur Carlosespicur marked this pull request as ready for review July 4, 2025 07:39
@Carlosespicur Carlosespicur force-pushed the feature/idl-parser-builtin-annotations branch 4 times, most recently from 94991d9 to b787c9f Compare July 14, 2025 06:19
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 14, 2025
@Carlosespicur Carlosespicur requested review from MiguelCompany and removed request for MiguelCompany July 14, 2025 09:51
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
…otated without parameters

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
…nd tests

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
…eral type in type descriptor

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
…e member in MemberDescriptor

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
…member in MemberDescriptor

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
…nums/bitmasks

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur force-pushed the feature/idl-parser-builtin-annotations branch from d9b5172 to 9256ace Compare July 23, 2025 10:42
@Carlosespicur Carlosespicur requested review from MiguelCompany and removed request for MiguelCompany July 23, 2025 10:44
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur force-pushed the feature/idl-parser-builtin-annotations branch from 90010c9 to f84775f Compare July 24, 2025 07:36
@Carlosespicur Carlosespicur requested review from MiguelCompany and removed request for MiguelCompany July 24, 2025 07:39
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@Carlosespicur Carlosespicur requested review from MiguelCompany and removed request for MiguelCompany July 28, 2025 05:59
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
@MiguelCompany MiguelCompany merged commit 52b6924 into master Jul 29, 2025
48 of 57 checks passed
@MiguelCompany MiguelCompany deleted the feature/idl-parser-builtin-annotations branch July 29, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants