Skip to content

[22970] Bump to asio 1.34.2 (backport #5896)#5907

Merged
MiguelCompany merged 2 commits into2.14.xfrom
bp/2.14.x/pr-5896
Jul 3, 2025
Merged

[22970] Bump to asio 1.34.2 (backport #5896)#5907
MiguelCompany merged 2 commits into2.14.xfrom
bp/2.14.x/pr-5896

Conversation

@Carlosespicur
Copy link
Copy Markdown
Contributor

@Carlosespicur Carlosespicur commented Jun 27, 2025

Description

This PR bumps thirdparty asio module to 1.34.2 release and fixes deprecated API related to io_service, address_v4, address_v6 and tcp::resolver, avoiding build failures. Fixes:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Carlosespicur Carlosespicur changed the base branch from master to 2.14.x June 27, 2025 07:07
@Carlosespicur Carlosespicur added this to the v2.14.5 milestone Jun 27, 2025
* Refs #22970: Bump to asio 1.34

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

* Refs #22970: Update thirdparty module to 1.34.2 release

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

* Refs #22970: Update versions.md

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

* Refs #22970: Uncrustify

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

* Refs #22970: Update Asio minimum version in CMakeLists

Signed-off-by: Carlosespicur <carlosespicur@proton.me>

---------

Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Jul 2, 2025
@EugenioCollado EugenioCollado self-requested a review July 2, 2025 10:53
Copy link
Copy Markdown
Contributor

@EugenioCollado EugenioCollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EugenioCollado EugenioCollado added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 3, 2025
@EugenioCollado
Copy link
Copy Markdown
Contributor

The test failing is unrelated to this PR and will be fixed in #5921. RTM with @MiguelCompany superpowers

@MiguelCompany MiguelCompany merged commit 59aa8bb into 2.14.x Jul 3, 2025
24 of 27 checks passed
@MiguelCompany MiguelCompany deleted the bp/2.14.x/pr-5896 branch July 3, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants