Skip to content

[23365] Add has_more_replies to WriteParams and SampleInfo#5898

Merged
MiguelCompany merged 9 commits intomasterfrom
feature/extend-related-sample-identity
Jul 1, 2025
Merged

[23365] Add has_more_replies to WriteParams and SampleInfo#5898
MiguelCompany merged 9 commits intomasterfrom
feature/extend-related-sample-identity

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Jun 23, 2025 •
edited
Loading

Description

This PR allows indicating in @feed annotated operations that a reply is not the last one in the feed.
It can also be used for other custom use-cases.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany mentioned this pull request Jun 23, 2025
Merged
7 tasks
@MiguelCompany MiguelCompany added this to the v3.3.0 milestone Jun 24, 2025
@Mario-DL
Copy link
Copy Markdown
Contributor

Mario-DL commented Jun 26, 2025 •
edited
Loading

Implementation LGTM
Tests, doc and versions pending.

NIT: In the description clarify that it only affects to operations annotated with @feed in the result

@MiguelCompany MiguelCompany force-pushed the feature/extend-related-sample-identity branch 2 times, most recently from 17c2e28 to a33d9bd Compare June 30, 2025 14:42
@MiguelCompany MiguelCompany requested a review from Mario-DL June 30, 2025 14:43
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 30, 2025
@MiguelCompany MiguelCompany added doc-pending Issue or PR which is pending to be documented and removed ci-pending PR which CI is running labels Jun 30, 2025
@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Jun 30, 2025

NIT: In the description clarify that it only affects to operations annotated with @feed in the result

The fact that we are only going to use it for @feed RPC operations does not mean that it cannot be used for something else.

@MiguelCompany MiguelCompany force-pushed the feature/extend-related-sample-identity branch from a33d9bd to b6d8fba Compare July 1, 2025 05:52
@MiguelCompany MiguelCompany requested review from Mario-DL and removed request for Mario-DL July 1, 2025 05:52
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 1, 2025
@MiguelCompany MiguelCompany force-pushed the feature/extend-related-sample-identity branch from b6d8fba to 29c739a Compare July 1, 2025 06:00
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima July 1, 2025 06:01
Mario-DL
Mario-DL previously approved these changes Jul 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany mentioned this pull request Jul 1, 2025
Merged
7 tasks
@MiguelCompany MiguelCompany removed the doc-pending Issue or PR which is pending to be documented label Jul 1, 2025
@Mario-DL Mario-DL removed the ci-pending PR which CI is running label Jul 1, 2025
@MiguelCompany
Refs #23365. Rule of zero in SampleIdentity.
4431b7a 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23365. Add new filed to SampleIdentity.
0c96f0a 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23365. Add (de)serializatrion of new field.
a3ae035 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23365. Move new filed to WriteParams.
c567016 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23365. Return new field in SampleInfo.
05b7c0d 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23365. Use new field when sending reply.
b69428c 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23365. Add blackbox test.
8dad104 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23365. Make transmission of new flag independent of related_sam…
1edbaba 
…ple_identity.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #23365. Update versions.md
0aadcf9 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the feature/extend-related-sample-identity branch from 29c739a to 0aadcf9 Compare July 1, 2025 14:42
@Mario-DL Mario-DL added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 1, 2025
@MiguelCompany MiguelCompany merged commit 428366b into master Jul 1, 2025
4 checks passed
@MiguelCompany MiguelCompany deleted the feature/extend-related-sample-identity branch July 1, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Mario-DL Mario-DL Mario-DL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v3.3.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @Mario-DL