Skip to content

[23372] Process key-only payloads#5897

Merged
MiguelCompany merged 19 commits intomasterfrom
feature/is_serialized_key_flag
Jul 1, 2025
Merged

[23372] Process key-only payloads#5897
MiguelCompany merged 19 commits intomasterfrom
feature/is_serialized_key_flag

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany commented Jun 20, 2025 •
edited by Mario-DL
Loading

Description

This PR adds a new field to SerializedPayload_t to identify payloads that only have the serialization of the key of the data type.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.3.0 milestone Jun 20, 2025
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 20, 2025 11:07
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 20, 2025
@MiguelCompany MiguelCompany force-pushed the feature/is_serialized_key_flag branch from 7b8bc47 to 01d6e5a Compare June 23, 2025 08:13
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 23, 2025 08:13
@MiguelCompany MiguelCompany marked this pull request as ready for review June 24, 2025 10:00
@MiguelCompany MiguelCompany removed the request for review from richiprosima June 24, 2025 10:23
@MiguelCompany MiguelCompany force-pushed the feature/is_serialized_key_flag branch from e9768fe to 45ffd29 Compare June 24, 2025 13:30
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 24, 2025 13:30
@MiguelCompany MiguelCompany force-pushed the feature/is_serialized_key_flag branch from d538497 to ac0a79b Compare June 25, 2025 13:08
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 25, 2025 13:12
@rsanchez15 rsanchez15 requested a review from Mario-DL June 26, 2025 06:27
Mario-DL
Mario-DL suggested changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments below I think we should always pass the filter in the ReaderProxy::rtps_is_relevant() method to avoid any key-only payload filtering on the writer side

@MiguelCompany
Copy link
Copy Markdown
Member Author

MiguelCompany commented Jun 30, 2025

I think we should always pass the filter in the ReaderProxy::rtps_is_relevant() method to avoid any key-only payload filtering on the writer side

@Mario-DL Since we never create changes with key-only payloads, we don't need this, IMHO.

@MiguelCompany MiguelCompany force-pushed the feature/is_serialized_key_flag branch 3 times, most recently from 2a90b82 to 4b4ab4b Compare June 30, 2025 10:37
@MiguelCompany MiguelCompany requested a review from Mario-DL June 30, 2025 13:28
Mario-DL
Mario-DL previously approved these changes Jun 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI.
versions.md commit pending

@MiguelCompany
Refs #22901. Add is_serialized_key to SerializedPayload_t.
95811f6 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Fill is_serialized_key in MessageReceiver.
19ad49d 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Handle is_serialized_key in SerializedPayload methods.
22f0acd 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Never filter out key-only payloads
32f0114 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Handle is_serialized_key on CacheChange
c3b4004 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Handle is_serialized_key on payload pools.
251bf9f 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Handle is_serialized_key in DDSFilterExpression.
4b8edd3 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Remove TODO.
c29c6c4 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Add BB test.
0de8af2 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Handle key computation failure in DataReaderHistory.
1f41964 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Fix encapsulation header in test.
d5dec35 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Fix comment in test.
bc7ac3b 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Use CV in test.
6b9828e 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Extend test with fragmented data.
0417cf4 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Extend fragment management unit test.
a0a2c32 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Add unit test in DDSSQLFilterValueTests.
e8c4da5 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Bonus point: fix change kind in data frag processing.
c5a5016 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #22901. Add feature to versions.md.
7418f24 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the feature/is_serialized_key_flag branch from e8c7b55 to 7418f24 Compare July 1, 2025 05:40
Mario-DL
Mario-DL suggested changes Jul 1, 2025
View reviewed changes
@MiguelCompany MiguelCompany requested a review from Mario-DL July 1, 2025 07:29
@MiguelCompany @Mario-DL
Apply suggestion
753676f 
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the feature/is_serialized_key_flag branch from 9237db2 to 753676f Compare July 1, 2025 07:32
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima July 1, 2025 07:32
Mario-DL
Mario-DL approved these changes Jul 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit de7e952 into master Jul 1, 2025
22 checks passed
@MiguelCompany MiguelCompany deleted the feature/is_serialized_key_flag branch July 1, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Mario-DL Mario-DL Mario-DL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v3.3.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @Mario-DL