Skip to content

[22469] Avoid calling setIPv4 in TCPTransportInterface (backport #5492)#5892

Merged
MiguelCompany merged 1 commit into3.2.xfrom
mergify/bp/3.2.x/pr-5492
Jun 20, 2025
Merged

[22469] Avoid calling setIPv4 in TCPTransportInterface (backport #5492)#5892
MiguelCompany merged 1 commit into3.2.xfrom
mergify/bp/3.2.x/pr-5492

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Jun 19, 2025

Description

This PR adds a new method copyAddress which allows to copy the whole address of one locator to another. It uses this method to replace the setIPv4 method of TCPTransportInterace introduced in #5382 which caused undesired warnings.

It also excludes TCPv6 cases from this logic, leaving TCPv6 comms as before #5382.

@Mergifyio backport 3.1.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • N/A Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5492 done by [Mergify](https://mergify.com).

* Refs #22469: Regression Tests for IPv6

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #22469: New method copyAddress

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #22469: Fix TCPTransportInterface

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #22469: Apply Review

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #22469: Disable grouping of locators in single channel for TCPv6

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #22469: Uncrustify

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #22469: Apply review

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #22469: Allow to copyIPv4 between two locators

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #22469: Apply Review 2

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit f2a55e9)
@MiguelCompany MiguelCompany added this to the v3.2.3 milestone Jun 19, 2025
@MiguelCompany MiguelCompany self-requested a review June 19, 2025 15:01
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 19, 2025
@MiguelCompany MiguelCompany merged commit ac0536e into 3.2.x Jun 20, 2025
22 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.2.x/pr-5492 branch June 20, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants