Skip to content

[23362] Apply changes of uncrustify to all IPP files#5891

Merged
MiguelCompany merged 1 commit intomasterfrom
fix/uncrust_ipp
Jun 20, 2025
Merged

[23362] Apply changes of uncrustify to all IPP files#5891
MiguelCompany merged 1 commit intomasterfrom
fix/uncrust_ipp

Conversation

@Javgilavi
Copy link
Copy Markdown
Contributor

@Javgilavi Javgilavi commented Jun 19, 2025

Description

This PR apply all the changes requested by uncrustify in all the .ipp files on fasdds.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Javgilavi Javgilavi added this to the v3.3.0 milestone Jun 19, 2025
@Javgilavi Javgilavi requested a review from richiware June 19, 2025 09:34
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 19, 2025
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't apply linters to generated code, so we don't need to change the *CdrAux.ipp files.

Third-party code does not apply either.

@MiguelCompany MiguelCompany added no-test Skip CI tests if PR marked with this label and removed ci-pending PR which CI is running labels Jun 19, 2025
Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiware June 19, 2025 12:50
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 19, 2025
@MiguelCompany MiguelCompany removed the request for review from richiprosima June 19, 2025 12:50
@MiguelCompany MiguelCompany merged commit 5eefc84 into master Jun 20, 2025
16 checks passed
@MiguelCompany MiguelCompany deleted the fix/uncrust_ipp branch June 20, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants