Skip to content

[23248] Fix DS initialization on "any" if no interfaces are available (backport #5850)#5877

Merged
cferreiragonz merged 2 commits into2.14.xfrom
mergify/bp/2.14.x/pr-5850
Jul 24, 2025
Merged

[23248] Fix DS initialization on "any" if no interfaces are available (backport #5850)#5877
cferreiragonz merged 2 commits into2.14.xfrom
mergify/bp/2.14.x/pr-5850

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jun 16, 2025

Description

This PR fixes a bug in which the Discovery Server initialization failed when configured to listen on any (0.0.0.0) if no interfaces were available.
It also adds a new suite of tests creating an scenario simulating that no interfaces are available, extending the test_transport functionality of simulate_no_interfaces.

This PR fixes #5835.

@Mergifyio backport 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.
    -N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5850 done by [Mergify](https://mergify.com).

@cferreiragonz cferreiragonz added this to the v2.14.5 milestone Jun 16, 2025
@EugenioCollado EugenioCollado force-pushed the mergify/bp/2.14.x/pr-5850 branch from 941be4f to 54f5ea3 Compare July 2, 2025 10:14
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Jul 2, 2025
@EugenioCollado EugenioCollado self-requested a review July 2, 2025 10:15
@EugenioCollado
Copy link
Copy Markdown
Contributor

@mergify rebase flaky_test_2_14_x

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Jul 10, 2025

rebase flaky_test_2_14_x

✅ Branch has been successfully rebased

@EugenioCollado EugenioCollado force-pushed the mergify/bp/2.14.x/pr-5850 branch 2 times, most recently from ca4f44f to 7c3984d Compare July 10, 2025 08:10
@EugenioCollado
Copy link
Copy Markdown
Contributor

@mergify rebase 2.14.x

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Jul 10, 2025

rebase 2.14.x

☑️ Nothing to do, the required conditions are not met

Details
  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

@EugenioCollado EugenioCollado force-pushed the mergify/bp/2.14.x/pr-5850 branch from 7c3984d to 809ad9b Compare July 10, 2025 12:37
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima July 10, 2025 13:29
* Refs #23248: Add regression test

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23248: Use localhost if no interfaces are found

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23248: Fix permissions of .bash

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

* Refs #23248: NITs

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>

---------

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
(cherry picked from commit 4e6a68f)
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz force-pushed the mergify/bp/2.14.x/pr-5850 branch from bed0008 to 503bc2f Compare July 22, 2025 09:02
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima July 22, 2025 09:02
@cferreiragonz cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 23, 2025
@cferreiragonz cferreiragonz merged commit cea1185 into 2.14.x Jul 24, 2025
26 of 29 checks passed
@cferreiragonz cferreiragonz deleted the mergify/bp/2.14.x/pr-5850 branch July 24, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants