Skip to content

[23269] Branch out 3.3.x#5853

Merged
rsanchez15 merged 3 commits intomasterfrom
branchout/3.3.x
Jun 9, 2025
Merged

[23269] Branch out 3.3.x#5853
rsanchez15 merged 3 commits intomasterfrom
branchout/3.3.x

Conversation

@Mario-DL
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL commented Jun 4, 2025

Description

This PR brings the branch out for 3.3.x including:

  • Update mirror workflow to 3.3.x
  • Include 3.2.x as supported branch for backporting improvements and fixes
  • Add 3.2.x nightly workflows

Note: Bumping project's version is left for the corresponding bump to 3.3.0

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • N/A Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.3 milestone Jun 4, 2025
Base automatically changed from eol/3.1.x/pr-template to master June 4, 2025 13:34
Mario-DL added 3 commits June 4, 2025 15:50
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@MiguelCompany
Copy link
Copy Markdown
Member

Note: Bumping project's version is left for the corresponding bump to 3.3.0

We should do this so the generated libraries already have a new version in the filename.
Also to allow generated code to require version 3.3 when necessary.

@Mario-DL
Copy link
Copy Markdown
Contributor Author

Mario-DL commented Jun 5, 2025

Note: Bumping project's version is left for the corresponding bump to 3.3.0

We should do this so the generated libraries already have a new version in the filename. Also to allow generated code to require version 3.3 when necessary.

In that case, I think we should either address, remove or forward to 3.4.x all the FASTDDS_TODO_BEFORE(3,3) otherwise we will fail

@MiguelCompany
Copy link
Copy Markdown
Member

In that case, I think we should either address, remove or forward to 3.4.x all the FASTDDS_TODO_BEFORE(3,3) otherwise we will fail

You are right, let's leave the bump till we have implemented those.

@rsanchez15 rsanchez15 added the skip-ci Automatically pass CI label Jun 9, 2025
@rsanchez15 rsanchez15 merged commit 2edace0 into master Jun 9, 2025
3 checks passed
@rsanchez15 rsanchez15 deleted the branchout/3.3.x branch June 9, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-ci Automatically pass CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants