Skip to content

[22800] Remove 3.1.x from PR template and nighties for 3.1.x and 2.10.x#5852

Merged
MiguelCompany merged 3 commits intomasterfrom
eol/3.1.x/pr-template
Jun 4, 2025
Merged

[22800] Remove 3.1.x from PR template and nighties for 3.1.x and 2.10.x#5852
MiguelCompany merged 3 commits intomasterfrom
eol/3.1.x/pr-template

Conversation

@Mario-DL
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL commented Jun 4, 2025

Description

Fast DDS v3.1.3 will be the EOL release of 3.1.x. Leveraging that the milestone is already frozen, this PR removes 3.1.x from PR template and its nighties along with 2.10.x ones since it is EOL

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • N/A Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v3.2.3 milestone Jun 4, 2025
@Mario-DL Mario-DL added the skip-ci Automatically pass CI label Jun 4, 2025
cferreiragonz
cferreiragonz previously approved these changes Jun 4, 2025
@Mario-DL Mario-DL changed the title [22800] Remove 3.1.x from PR template [22800] Remove 3.1.x from PR template and nighties Jun 4, 2025
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@MiguelCompany
Copy link
Copy Markdown
Member

@Mario-DL Would you mind also removing 2.10.x from the nightlies?

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL changed the title [22800] Remove 3.1.x from PR template and nighties [22800] Remove 3.1.x from PR template and nighties for 3.1.x and 2.10.x Jun 4, 2025
@Mario-DL Mario-DL changed the title [22800] Remove 3.1.x from PR template and nighties for 3.1.x and 2.10.x [22800] Remove 3.1.x from PR template and nighties for 3.1.x and 2.10.x Jun 4, 2025
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also move 3.1 and 2.10 from the supported versions to the previously-supported table in RELEASE_SUPPORT.md

@MiguelCompany
Copy link
Copy Markdown
Member

Let's also move 3.1 and 2.10 from the supported versions to the previously-supported table in RELEASE_SUPPORT.md

I'd do this in a different PR after they have been released, so we can merge this one now (it is already in the release checklist)

Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@MiguelCompany MiguelCompany merged commit f0ce10a into master Jun 4, 2025
2 checks passed
@MiguelCompany MiguelCompany deleted the eol/3.1.x/pr-template branch June 4, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-ci Automatically pass CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants