Skip to content

[23183] Allow ResourceLimitsQos serialization method compatibility#5813

Merged
cferreiragonz merged 7 commits intomasterfrom
fix/compatibility_qos_serializer
May 19, 2025
Merged

[23183] Allow ResourceLimitsQos serialization method compatibility#5813
cferreiragonz merged 7 commits intomasterfrom
fix/compatibility_qos_serializer

Conversation

@cferreiragonz
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz commented May 14, 2025

Description

This PR ensures compatibility between older versions and other vendors when serializing the ResourceLimitsQosPolicy, introduced in #5795.

It also provides new methods to check the Vendor_id when de-serializing CDR messages.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz added this to the v3.2.3 milestone May 14, 2025
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comments below, this needs tests to be added in BuiltinDataSerializationTests

Comment thread src/cpp/fastdds/core/policy/QosPoliciesSerializer.hpp Outdated
Comment thread src/cpp/fastdds/core/policy/QosPoliciesSerializer.hpp Outdated
Comment thread src/cpp/fastdds/core/policy/QosPoliciesSerializer.hpp Outdated
@Mario-DL
Copy link
Copy Markdown
Contributor

Good catch @MiguelCompany

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz force-pushed the fix/compatibility_qos_serializer branch from 45caab6 to 0a01cb6 Compare May 14, 2025 13:37
@github-actions github-actions Bot added the ci-pending PR which CI is running label May 14, 2025
Comment thread test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp Outdated
Comment thread test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp Outdated
Comment thread test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp Outdated
Comment thread test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp Outdated
Comment thread test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp Outdated
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima May 14, 2025 15:04
@cferreiragonz cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 19, 2025
@cferreiragonz cferreiragonz merged commit ea69181 into master May 19, 2025
17 checks passed
@cferreiragonz cferreiragonz deleted the fix/compatibility_qos_serializer branch May 19, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants