[23088] Solve Discovery Server race conditions (backport #5780)#5807
Merged
MiguelCompany merged 5 commits into2.14.xfrom Jul 29, 2025
Merged
[23088] Solve Discovery Server race conditions (backport #5780)#5807MiguelCompany merged 5 commits into2.14.xfrom
MiguelCompany merged 5 commits into2.14.xfrom
Conversation
Contributor
Author
|
Cherry-pick of ec666f7 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
11 tasks
Contributor
|
Merge after: |
e3a52ee to
4c8fe1b
Compare
cferreiragonz
previously approved these changes
Jul 24, 2025
Contributor
|
I backported the |
3112f77 to
60f4f42
Compare
* Refs #23088: Test reconnection when removing participant Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #23088: Solve EDP-PDP queues race condition Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #23088: Solve data UP + data P race condition Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #23088: Abort writer/reader processing if associated participant not alive Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #23088: Apply suggestions Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #23088: Release change when writer/reader insertion in DB failed Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #23088: Match servers after change update Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> Co-authored-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit ec666f7) # Conflicts: # src/cpp/rtps/builtin/discovery/database/DiscoveryDataBase.cpp # test/blackbox/common/BlackboxTestsDiscovery.cpp
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
60f4f42 to
eaa6b1d
Compare
cferreiragonz
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to fix a couple of race conditions detected in scenarios where a large number of clients are present:
@Mergifyio backport 3.1.x 2.14.x 2.10.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5780 done by [Mergify](https://mergify.com).