Skip to content

[22427] Fast DDS EASY_MODE - Feature - XMLRPC Server#5551

Merged
Mario-DL merged 23 commits intofeature/auto_ds_daemonizedfrom
feature/fastdds-impl/auto_ds_daemonized
Jan 22, 2025
Merged

[22427] Fast DDS EASY_MODE - Feature - XMLRPC Server#5551
Mario-DL merged 23 commits intofeature/auto_ds_daemonizedfrom
feature/fastdds-impl/auto_ds_daemonized

Conversation

@cferreiragonz
Copy link
Copy Markdown
Contributor

@cferreiragonz cferreiragonz commented Jan 8, 2025

Description

This PR implements the Fast DDS Auto Discovery Server Mode feature in Fast DDS.

  • It updates the RTPSDomain to parse the new environment variable EASY_MODE and properly configure the RTPSParticipant to point to a local UDP Discovery Server.
  • It adds a new builtin transport: P2P, targeting the new mode. It instantiates TCP and SHM transport for user data and UDP for metatrafficUnicast, relying on a Discovery Server for discovery purposes.
  • It add a new class SystemCommandBuilder to build and make system calls within Fast DDS.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 8, 2025
@cferreiragonz cferreiragonz force-pushed the feature/fastdds-impl/auto_ds_daemonized branch from 4df67d4 to 1d15ef7 Compare January 8, 2025 13:58
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima January 8, 2025 13:58
@cferreiragonz cferreiragonz changed the base branch from master to feature/auto_ds_daemonized January 8, 2025 14:02
@cferreiragonz cferreiragonz added doc-pending Issue or PR which is pending to be documented versions-pending needs-review PR that is ready to be reviewed labels Jan 8, 2025
@cferreiragonz cferreiragonz force-pushed the feature/auto_ds_daemonized branch 3 times, most recently from e7c0a85 to 6465cd4 Compare January 10, 2025 09:38
@Mario-DL Mario-DL mentioned this pull request Jan 10, 2025
13 tasks
@Mario-DL Mario-DL force-pushed the feature/fastdds-impl/auto_ds_daemonized branch from 5fdf099 to 96ef6db Compare January 10, 2025 10:28
@cferreiragonz cferreiragonz force-pushed the feature/fastdds-impl/auto_ds_daemonized branch from 5a156eb to 89506ac Compare January 13, 2025 15:37
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima January 14, 2025 07:24
@cferreiragonz cferreiragonz force-pushed the feature/auto_ds_daemonized branch from 55a05c7 to 308bc53 Compare January 15, 2025 13:50
@cferreiragonz cferreiragonz force-pushed the feature/fastdds-impl/auto_ds_daemonized branch from 353bcec to 5917ac4 Compare January 15, 2025 13:58
@cferreiragonz cferreiragonz force-pushed the feature/auto_ds_daemonized branch from 308bc53 to b03c362 Compare January 15, 2025 14:18
@cferreiragonz cferreiragonz force-pushed the feature/fastdds-impl/auto_ds_daemonized branch 3 times, most recently from 6f8ddb5 to 351c441 Compare January 15, 2025 16:09
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima January 15, 2025 16:10
@cferreiragonz cferreiragonz force-pushed the feature/auto_ds_daemonized branch from b03c362 to e89400a Compare January 16, 2025 10:16
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima January 20, 2025 15:26
@Mario-DL Mario-DL requested review from Mario-DL and removed request for Mario-DL January 21, 2025 09:54
@cferreiragonz cferreiragonz force-pushed the feature/auto_ds_daemonized branch from a18b029 to 61f3cd7 Compare January 21, 2025 14:28
Mario-DL and others added 23 commits January 21, 2025 16:03
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
… BB tests

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
… a previous one

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: Mario Domínguez López <mariodominguez@eprosima.com>
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @cferreiragonz 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants