Log any errors before cancel_init() (backport #5530)#5546
Merged
EugenioCollado merged 2 commits into2.14.xfrom Jan 14, 2025
Merged
Log any errors before cancel_init() (backport #5530)#5546EugenioCollado merged 2 commits into2.14.xfrom
EugenioCollado merged 2 commits into2.14.xfrom
Conversation
* Log any errors before cancel_init() Signed-off-by: Santti4go <santiaupi@gmail.com> * Code style Signed-off-by: Santti4go <santiaupi@gmail.com> * Apply suggestion Signed-off-by: Santti4go <santiaupi@gmail.com> --------- Signed-off-by: Santti4go <santiaupi@gmail.com> (cherry picked from commit 165d64e)
10 tasks
15 tasks
* Regression tests Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Update log macro Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Uncrustify Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> * Fix CI log flush Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> --------- Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Contributor
|
Backported commit 25b117fcf |
Contributor
|
@Mergifyio rebase |
Contributor
Author
✅ Nothing to do for rebase action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the debugging process by adding a proper logging right before running
SecurityManager::cancel_init()in this catch blockDescription
More details in this ticket #5531
@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x
Fixes #(issue)
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
NA Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
NA Any new/modified methods have been properly documented using Doxygen.
NA Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
NA New feature has been added to the
versions.mdfile (if applicable).NA New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5530 done by [Mergify](https://mergify.com).