Skip to content

[22353] Use correct algorithm strings on PermissionsToken and IdentityToken (backport #5450)#5482

Merged
juanlofer-eprosima merged 1 commit into2.14.xfrom
mergify/bp/2.14.x/pr-5450
Dec 31, 2024
Merged

[22353] Use correct algorithm strings on PermissionsToken and IdentityToken (backport #5450)#5482
juanlofer-eprosima merged 1 commit into2.14.xfrom
mergify/bp/2.14.x/pr-5450

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Dec 11, 2024

Description

This PR changes the strings transmitted in dds.cert.algo, dds.ca.algo, and dds.perm_ca.algo to the ones
specified in DDS-SEC-1.1.

In order to provide interoperability with legacy implementations, a new transmit_algorithms_as_legacy sub-property has been added to the builtin plugins configuration properties.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5450 done by [Mergify](https://mergify.com).

@MiguelCompany MiguelCompany added this to the v2.14.5 milestone Dec 11, 2024
@EugenioCollado EugenioCollado self-requested a review December 27, 2024 09:45
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 27, 2024
@EugenioCollado
Copy link
Copy Markdown
Contributor

EugenioCollado commented Dec 31, 2024

@Mergifyio rebase

…5450)

* Refs #19925. Add conversion methods for token algorithms.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #19925. Configure legacy transmission on PKIDH.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #19925. Configure legacy transmission on Permissions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #19925. Add blackbox test.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #19925. Add doxygen documentation to new methods.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 971f120)
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Dec 31, 2024

rebase

✅ Branch has been successfully rebased

Copy link
Copy Markdown
Contributor

@EugenioCollado EugenioCollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit 0f38526 into 2.14.x Dec 31, 2024
@juanlofer-eprosima juanlofer-eprosima deleted the mergify/bp/2.14.x/pr-5450 branch December 31, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants