[22441] Improve Blackbox TCP tests suite (backport #5467)#5477
Merged
MiguelCompany merged 1 commit into2.10.xfrom May 28, 2025
Merged
[22441] Improve Blackbox TCP tests suite (backport #5467)#5477MiguelCompany merged 1 commit into2.10.xfrom
MiguelCompany merged 1 commit into2.10.xfrom
Conversation
Contributor
Author
|
Cherry-pick of 0c799f4 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
11 tasks
35ad18a to
69a192b
Compare
* Refs #22441: Avoid running duplicated TCP tests Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22441: Avoid using parametrized test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> * Refs #22441: Equal operator test Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> --------- Signed-off-by: cferreiragonz <carlosferreira@eprosima.com> (cherry picked from commit 0c799f4) Solve conflicts Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
69a192b to
25ca19b
Compare
MiguelCompany
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Blackbox TCP tests are run twice, once with IPv4 and once with IPv6 configurations. However, some of the tests do not properly utilize this architecture feature, leading to duplicated test runs. This PR fixes those tests by leveraging the test architecture to avoid running the same tests twice and reducing the number of tests.
@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5467 done by [Mergify](https://mergify.com).