Skip to content

[21364] Remove double // in some installation paths (backport #5111) (backport #5129)#5254

Merged
MiguelCompany merged 1 commit into2.10.xfrom
mergify/bp/2.10.x/pr-5129
Oct 17, 2024
Merged

[21364] Remove double // in some installation paths (backport #5111) (backport #5129)#5254
MiguelCompany merged 1 commit into2.10.xfrom
mergify/bp/2.10.x/pr-5129

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Sep 24, 2024

Description

Some installation paths contained a //, this PR fixes those, even though they are not harmful.

@Mergifyio backport 2.14.x

IMPORTANT: Same change needs to be backported to 2.10.x, but it'd be easier from the 2.14.x PR.

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A: The code follows the style guidelines of this project.

  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A: Any new/modified methods have been properly documented using Doxygen.

  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • N/A: Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5111 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #5129 done by [Mergify](https://mergify.com).

Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit 8c477dc)

# Conflicts:
#	CMakeLists.txt

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
(cherry picked from commit 28a2729)
@MiguelCompany MiguelCompany added this to the v2.10.6 milestone Sep 24, 2024
@JesusPoderoso JesusPoderoso self-requested a review September 24, 2024 07:21
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 24, 2024
Copy link
Copy Markdown
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso
Copy link
Copy Markdown
Contributor

CI issues are unrelated to the PR
Ready to merge!

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 17, 2024
@MiguelCompany MiguelCompany merged commit 95cd15a into 2.10.x Oct 17, 2024
@MiguelCompany MiguelCompany deleted the mergify/bp/2.10.x/pr-5129 branch October 17, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants