Skip to content

Making UDP non-blocking send optional [5362]#523

Merged
richiware merged 1 commit intorelease/1.8.0from
feature/option-non-blocking-udp
May 13, 2019
Merged

Making UDP non-blocking send optional [5362]#523
richiware merged 1 commit intorelease/1.8.0from
feature/option-non-blocking-udp

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

No description provided.

@richiware
Copy link
Copy Markdown
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany
Copy link
Copy Markdown
Member Author

Windows build passed and then jenkins agent connection failed.

Copy link
Copy Markdown
Contributor

@raquelalvarezbanos raquelalvarezbanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should we add a section to the docs, given that the new parameter can be configured by the user?

@MiguelCompany
Copy link
Copy Markdown
Member Author

Should we add a section to the docs?

Sure! We should add it to the XML configuration page, and add a paragraph to the transport section.

@richiware richiware merged commit cb44b6b into release/1.8.0 May 13, 2019
@richiware richiware deleted the feature/option-non-blocking-udp branch May 13, 2019 05:12
@richiware
Copy link
Copy Markdown
Member

The failed job was caused by jenkins failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants