Skip to content

[Backport]Fix communication tests not run (#3614)#5204

Closed
roscan-tech wants to merge 1 commit intoeProsima:2.10.xfrom
roscan-tech:bp/2.10.x/pr-3614
Closed

[Backport]Fix communication tests not run (#3614)#5204
roscan-tech wants to merge 1 commit intoeProsima:2.10.xfrom
roscan-tech:bp/2.10.x/pr-3614

Conversation

@roscan-tech
Copy link
Copy Markdown

@roscan-tech roscan-tech commented Sep 6, 2024

  • Refs #19054: Fix communication tests not runned

  • Refs #19054: Clean before running the test

  • Refs #19054: Make test_wrapper.cmake a configurable file

  • Refs #19054: Fix missing python path

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso @EduPonz @roscan-tech
Fix communication tests not run (eProsima#3614)
f84c86b 
* Refs #19054: Fix communication tests not runned

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19054: Clean before running the test

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19054: Make test_wrapper.cmake a configurable file

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19054: Fix missing python path

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: roscan-tech <liwei378@mail2.sysu.edu.cn>
@JesusPoderoso
Copy link
Copy Markdown
Contributor

JesusPoderoso commented Sep 10, 2024

Hi @roscan-tech, thanks for your contribution.
Unfortunately, the original PR was not backported because it contains a behavior change.
For that reason, I am closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roscan-tech @JesusPoderoso