Skip to content

[21469] Fix windows issue with flow controller example#5142

Merged
juanlofer-eprosima merged 5 commits intomasterfrom
hotfix/21469
Aug 8, 2024
Merged

[21469] Fix windows issue with flow controller example#5142
juanlofer-eprosima merged 5 commits intomasterfrom
hotfix/21469

Conversation

@JesusPoderoso
Copy link
Copy Markdown
Contributor

@JesusPoderoso JesusPoderoso commented Aug 7, 2024

Description

During release testing, a crash in the flow controller example was caught. This PR fixes windows build in Debug mode, and fixes the crash in the flow controller example execution.

Edit: it has been added also a commit setting the extensibility explicitly, and regenerating the example types.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Raúl Sánchez-Mateos Lizano <raul@eprosima.com>
Signed-off-by: Raúl Sánchez-Mateos Lizano <raul@eprosima.com>
@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Aug 7, 2024
@JesusPoderoso JesusPoderoso requested a review from Mario-DL August 7, 2024 10:08
@JesusPoderoso JesusPoderoso self-assigned this Aug 7, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Aug 7, 2024
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested review from Mario-DL and removed request for Mario-DL August 7, 2024 11:55
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso JesusPoderoso requested a review from Mario-DL August 8, 2024 08:55
Copy link
Copy Markdown
Contributor

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit 817b14a into master Aug 8, 2024
@juanlofer-eprosima juanlofer-eprosima deleted the hotfix/21469 branch August 8, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants