Skip to content

[21364] Fix installation of some examples#5108

Merged
EduPonz merged 3 commits intomasterfrom
hotfix/examples_installation
Jul 29, 2024
Merged

[21364] Fix installation of some examples#5108
EduPonz merged 3 commits intomasterfrom
hotfix/examples_installation

Conversation

@EduPonz
Copy link
Copy Markdown

@EduPonz EduPonz commented Jul 26, 2024

Description

This PR fixes the installation the 3 examples that were not correctly installed:

  • Security
  • Custom payload pool
  • Delivery mechanisims

At the end of the day, all examples should be installed under <install_dir>/share/fastdds/examples/cpp

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

EduPonz added 3 commits July 26, 2024 12:28
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v3.0.0 milestone Jul 26, 2024
@EduPonz EduPonz requested a review from richiprosima July 26, 2024 10:49
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 26, 2024
@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 29, 2024
@EduPonz EduPonz removed the request for review from richiprosima July 29, 2024 05:13
@EduPonz EduPonz merged commit 3dd5cfe into master Jul 29, 2024
@EduPonz EduPonz deleted the hotfix/examples_installation branch July 29, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants