Skip to content

hotfix: Compile discovery server example in the CI#5094

Closed
elianalf wants to merge 1 commit intomasterfrom
hotfix/build_example
Closed

hotfix: Compile discovery server example in the CI#5094
elianalf wants to merge 1 commit intomasterfrom
hotfix/build_example

Conversation

@elianalf
Copy link
Copy Markdown
Contributor

@elianalf elianalf commented Jul 22, 2024

Description

This PR adds a flag to compile discovery server example in the colcon meta for the CI.
Related PR in Discovery-Server:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf added this to the v3.0.0 milestone Jul 22, 2024
@JesusPoderoso JesusPoderoso self-requested a review July 22, 2024 10:44
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jul 22, 2024
@rsanchez15
Copy link
Copy Markdown
Contributor

Decided to remove the example in the Discovery Server repository in favor of the one in this repository

@rsanchez15 rsanchez15 closed this Jul 22, 2024
@elianalf elianalf deleted the hotfix/build_example branch July 23, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants