[21183] const qualify all data related inputs in DataWriter APIs#4960
Merged
[21183] const qualify all data related inputs in DataWriter APIs#4960
const qualify all data related inputs in DataWriter APIs#4960Conversation
This was referenced Jun 18, 2024
MiguelCompany
requested changes
Jun 18, 2024
Member
MiguelCompany
left a comment
There was a problem hiding this comment.
Types under test/profiling folder need to be updated
3e8d288 to
91378b3
Compare
MiguelCompany
requested changes
Jun 19, 2024
91378b3 to
6cbb5ff
Compare
6cbb5ff to
c781520
Compare
MiguelCompany
previously approved these changes
Jun 19, 2024
…r APIs Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
Signed-off-by: eduponz <eduardoponz@eprosima.com>
…as override Signed-off-by: eduponz <eduardoponz@eprosima.com>
c781520 to
bf46800
Compare
MiguelCompany
previously approved these changes
Jun 21, 2024
Member
MiguelCompany
left a comment
There was a problem hiding this comment.
A nit that does not require running CI again
Signed-off-by: eduponz <eduardoponz@eprosima.com>
MiguelCompany
approved these changes
Jun 21, 2024
6 tasks
This was referenced Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR qualifies all the data related inputs from
DataWriterAPI asconst.Related PRs:
constqualification of all data related inputs in DataWriter APIs Fast-DDS-Gen#357constqualification of all data related inputs in DataWriter APIs Fast-DDS-python#142constqualification of all data related inputs in DataWriter APIs Fast-DDS-docs#817constqualification of all data related inputs in DataWriter APIs ShapesDemo#147constqualification of all data related inputs in DataWriter APIs Discovery-Server#88Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist