Skip to content

[20750] Add check for XML API to PR template (backport #4658)#4661

Merged
EduPonz merged 2 commits into2.6.xfrom
mergify/bp/2.6.x/pr-4658
Apr 16, 2024
Merged

[20750] Add check for XML API to PR template (backport #4658)#4661
EduPonz merged 2 commits into2.6.xfrom
mergify/bp/2.6.x/pr-4658

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Apr 4, 2024

Description

This PR adds a check for the PRs to add XML API if needed.

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A: The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • N/A Changes are ABI compatible.

  • N/A Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #4658 done by [Mergify](https://mergify.com).

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 5eeee69)

# Conflicts:
#	.github/pull_request_template.md
@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Apr 4, 2024
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Apr 4, 2024

Cherry-pick of 5eeee69 has failed:

On branch mergify/bp/2.6.x/pr-4658
Your branch is up to date with 'origin/2.6.x'.

You are currently cherry-picking commit 5eeee69b5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/pull_request_template.md

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@JesusPoderoso JesusPoderoso added this to the v2.6.8 milestone Apr 4, 2024
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added skip-ci Automatically pass CI and removed conflicts Backport PR wich git cherry pick failed labels Apr 10, 2024
@Mario-DL Mario-DL requested a review from EduPonz April 10, 2024 06:20
@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed skip-ci Automatically pass CI labels Apr 10, 2024
@EduPonz EduPonz merged commit 0439847 into 2.6.x Apr 16, 2024
@EduPonz EduPonz deleted the mergify/bp/2.6.x/pr-4658 branch April 16, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants