[20589] Set real TCP non_blocking_send limitation (backport #4502)#4631
Merged
MiguelCompany merged 1 commit into2.6.xfrom Apr 24, 2024
Merged
[20589] Set real TCP non_blocking_send limitation (backport #4502)#4631MiguelCompany merged 1 commit into2.6.xfrom
MiguelCompany merged 1 commit into2.6.xfrom
Conversation
Contributor
Author
|
Cherry-pick of 33eb8be has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
11 tasks
Contributor
|
@jepemi would you mind addressing the conflicts here ? |
* Refs #20589: Set real non_blocking_send limitation Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Readapt test Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix failing test in macos/linux Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Uncrustify Signed-off-by: Jesus Perez <jesusperez@eprosima.com> * Refs #20589: Fix unused variable Signed-off-by: Jesus Perez <jesusperez@eprosima.com> --------- Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
8466f95 to
73c5746
Compare
Contributor
|
@richiprosima please test this |
Mario-DL
approved these changes
Apr 24, 2024
Contributor
Mario-DL
left a comment
There was a problem hiding this comment.
LGTM. Failed tests are unrelated, going in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since TCP actually allocates twice the size of the requested buffer, TCP
non_blocking_sendshould not skip a send until this limit is reached.This PR doubles the limit from which a send should not be tried if TCP
non_blocking_sendis set to true.@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4502 done by [Mergify](https://mergify.com).