[20575] Examples refactor: Configuration#4570
Merged
Conversation
1f2e8b7 to
30d4fcd
Compare
c534f32 to
b83c0ac
Compare
b83c0ac to
90c3c52
Compare
2a521df to
1906de7
Compare
18d8c6e to
f3b3af6
Compare
eb6ba0c to
5d12211
Compare
Contributor
Author
|
112656b to
64e1e33
Compare
Mario-DL
suggested changes
Apr 10, 2024
Contributor
Mario-DL
left a comment
There was a problem hiding this comment.
Really good job with this PR, bringing a helpful configuration example refactor. I love the example testing automation.
Leaving some suggestions to review.
JesusPoderoso
commented
Apr 10, 2024
Contributor
|
@richiprosima please test_3 windows |
Contributor
|
@richiprosima please test_3 linux |
Contributor
|
@richiprosima test windows |
6b2eab7 to
704190d
Compare
Contributor
Author
|
@richiprosima please test_3 linux please test_3 windows |
Contributor
|
@JesusPoderoso would you mind rebasing so that Ubuntu CI and Docs pass CI ? |
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
704190d to
7e56555
Compare
Contributor
Author
|
@richiprosima please test_3 this |
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of a suite of PR which would make a refactor in the repository examples.
It is intended to apply to most of the examples, by making them homogeneous, more understandable, and more specific to the case they were meant to be.
In this configuration example, the key changes are:
The following changes apply to this and the remain examples:
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist