Skip to content

[20492] OpenOutputChannels / CloseOutputChannels that receive a LocatorSelectorEntry#4411

Merged
EduPonz merged 11 commits intomasterfrom
feature/output_channel_locator_entry_overload
Mar 6, 2024
Merged

[20492] OpenOutputChannels / CloseOutputChannels that receive a LocatorSelectorEntry#4411
EduPonz merged 11 commits intomasterfrom
feature/output_channel_locator_entry_overload

Conversation

@jepemi
Copy link
Copy Markdown
Contributor

@jepemi jepemi commented Feb 20, 2024 •
edited by EduPonz
Loading

Description

Introduce new OpenOutputChannels and CloseOutputChannels methods to the TransportInterface base class, both accepting a LocatorSelectorEntry argument. This enhancement provides improved control over creating or destroying communication channels between participants.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • ❌ Changes are ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v2.14.0 milestone Feb 21, 2024
@jepemi jepemi marked this pull request as ready for review February 21, 2024 07:37
MiguelCompany
MiguelCompany requested changes Feb 28, 2024
View reviewed changes
@jepemi jepemi force-pushed the feature/output_channel_locator_entry_overload branch from 3e81547 to d4a865d Compare February 28, 2024 10:38
MiguelCompany
MiguelCompany requested changes Feb 28, 2024
View reviewed changes
MiguelCompany
MiguelCompany previously approved these changes Feb 28, 2024
View reviewed changes
@MiguelCompany MiguelCompany added versions-pending ci-pending PR which CI is running labels Feb 28, 2024
MiguelCompany
MiguelCompany previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz added to-do and removed ci-pending PR which CI is running labels Feb 29, 2024
@jepemi jepemi force-pushed the feature/output_channel_locator_entry_overload branch 2 times, most recently from e6c8e7b to d6fcebe Compare March 1, 2024 12:34
@jepemi jepemi changed the base branch from master to bugfix/transport_sanitizer_event March 1, 2024 12:35
@jepemi jepemi force-pushed the feature/output_channel_locator_entry_overload branch from d6fcebe to f8e1dd4 Compare March 1, 2024 12:42
@jepemi jepemi force-pushed the bugfix/transport_sanitizer_event branch from 34e8205 to b72dd62 Compare March 4, 2024 06:50
@jepemi jepemi force-pushed the feature/output_channel_locator_entry_overload branch from f8e1dd4 to 2fac88d Compare March 4, 2024 07:32
@jepemi jepemi added needs-review PR that is ready to be reviewed and removed to-do versions-pending labels Mar 4, 2024
@jepemi jepemi force-pushed the feature/output_channel_locator_entry_overload branch from 5d66130 to ce9325d Compare March 4, 2024 13:58
@MiguelCompany MiguelCompany added the temporarily-blocked PR must be merged after another one label Mar 5, 2024
MiguelCompany
MiguelCompany approved these changes Mar 5, 2024
View reviewed changes
MiguelCompany
MiguelCompany requested changes Mar 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally approved

MiguelCompany
MiguelCompany previously approved these changes Mar 5, 2024
View reviewed changes
@MiguelCompany MiguelCompany removed the needs-review PR that is ready to be reviewed label Mar 5, 2024
@EduPonz EduPonz mentioned this pull request Mar 5, 2024
Merged
12 tasks
@EduPonz EduPonz force-pushed the bugfix/transport_sanitizer_event branch from 30aa7c1 to b479be8 Compare March 5, 2024 14:25
@EduPonz EduPonz force-pushed the feature/output_channel_locator_entry_overload branch from a004c1b to 2a5ad9c Compare March 5, 2024 14:29
Base automatically changed from bugfix/transport_sanitizer_event to master March 5, 2024 19:55
@EduPonz EduPonz dismissed MiguelCompany’s stale review March 5, 2024 19:55

The base branch was changed.

@EduPonz EduPonz force-pushed the feature/output_channel_locator_entry_overload branch from 2a5ad9c to 2a4de4a Compare March 5, 2024 19:57
@EduPonz
Copy link
Copy Markdown

EduPonz commented Mar 5, 2024

@richiprosima please test this

@EduPonz EduPonz added ci-pending PR which CI is running and removed temporarily-blocked PR must be merged after another one labels Mar 5, 2024
jepemi and others added 10 commits March 6, 2024 06:59
@jepemi @EduPonz
Refs #20492: New outputchannel related methods with locator selector …
6623fa8 
…entry argument

Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@jepemi @EduPonz
Refs #20492: Uncrustify
d26949e 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@jepemi @EduPonz
Refs #20492: Add dll
888378b 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@jepemi @EduPonz
Refs #20492: Apply suggestions
bde2024 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@jepemi @EduPonz
Refs #20492: Fix method description
29f76e0 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@jepemi @EduPonz
Refs #20492: Remove dll
0a8eb86 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@jepemi @EduPonz
Refs #20492: Fix build and add to versions
6736ada 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@jepemi @EduPonz
Refs #20492: Apply suggestions
1e48784 
Signed-off-by: Jesus Perez <jesusperez@eprosima.com>
@EduPonz
Refs #20492: Add TODO in NetworkFactory
21d5a23 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Refs #20492: Rename TCPTransportInterface::CloseOutputChannel to clea…
e4e2ca5 
…nup_sender_resources

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the feature/output_channel_locator_entry_overload branch from 2a4de4a to e4e2ca5 Compare March 6, 2024 07:31
@EduPonz
Copy link
Copy Markdown

EduPonz commented Mar 6, 2024

@richiprosima please test this

MiguelCompany
MiguelCompany previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz
Refs #20492: Rename new TransportInterface::Open|CloseOutputChannel t…
42edc5e 
…o Open|CloseOutputChannels

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz
Copy link
Copy Markdown

EduPonz commented Mar 6, 2024

@richiprosima please test this

@EduPonz EduPonz changed the title [20492] OpenOutputChannel / CloseOutputChannel that receive a LocatorSelectorEntry [20492] OpenOutputChannels / CloseOutputChannels that receive a LocatorSelectorEntry Mar 6, 2024
@EduPonz EduPonz merged commit f515668 into master Mar 6, 2024
@EduPonz EduPonz deleted the feature/output_channel_locator_entry_overload branch March 6, 2024 17:27
@cferreiragonz cferreiragonz mentioned this pull request Mar 20, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v2.14.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jepemi @EduPonz @MiguelCompany