Skip to content

[20257] Add a keyed fragmented change to the reader data instance only when its completed (backport #4261)#4305

Merged
EduPonz merged 2 commits into2.12.xfrom
mergify/bp/2.12.x/pr-4261
Mar 6, 2024
Merged

[20257] Add a keyed fragmented change to the reader data instance only when its completed (backport #4261)#4305
EduPonz merged 2 commits into2.12.xfrom
mergify/bp/2.12.x/pr-4261

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jan 27, 2024

This is an automatic backport of pull request #4261 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…ts completed (#4261)

* Refs #20257: Add regression test

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* #Refs #20257: Fix

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20239: Second rev suggestions

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20257: Linter

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

* Refs #20257: Retrieve instance handle condition before for avoid being nullptr

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit 9558ce4)
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL
Copy link
Copy Markdown
Contributor

@richiprosima please test linux

@Mario-DL
Copy link
Copy Markdown
Contributor

@richiprosima please test mac

@Mario-DL
Copy link
Copy Markdown
Contributor

@richiprosima please test discovery_server

@Mario-DL
Copy link
Copy Markdown
Contributor

@richiprosima please test mac

@elianalf
Copy link
Copy Markdown
Contributor

@richiprosima please test windows

@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 5, 2024
@EduPonz EduPonz merged commit 6a313ba into 2.12.x Mar 6, 2024
@EduPonz EduPonz deleted the mergify/bp/2.12.x/pr-4261 branch March 6, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants