Skip to content

Add serialization for Log::Kind to ostream#4292

Merged
EduPonz merged 3 commits intomasterfrom
feature/logKind-stream
Feb 10, 2024
Merged

Add serialization for Log::Kind to ostream#4292
EduPonz merged 3 commits intomasterfrom
feature/logKind-stream

Conversation

@LuciaEchevarria99
Copy link
Copy Markdown
Contributor

@LuciaEchevarria99 LuciaEchevarria99 commented Jan 25, 2024

Add serialization for Log::Kind to ostream

Description

This commit introduces a new ostream serialization function for the Log::Kind enumeration, allowing seamless output to ostream objects. The function includes a switch statement of Log::Kind values to their corresponding string representations (INFO, WARNING, ERROR).

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@LuciaEchevarria99 LuciaEchevarria99 added the no-test Skip CI tests if PR marked with this label label Jan 25, 2024
Copy link
Copy Markdown

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use this in LogConsumer::print_header

@EduPonz EduPonz removed the no-test Skip CI tests if PR marked with this label label Jan 25, 2024
@EduPonz
Copy link
Copy Markdown

EduPonz commented Jan 27, 2024

@LuciaEchevarria99 please address uncrustify failure

Copy link
Copy Markdown

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI 🏅

@EduPonz EduPonz removed the to-do label Feb 7, 2024
@JesusPoderoso
Copy link
Copy Markdown
Contributor

@Mergifyio rebase

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 8, 2024

rebase

✅ Branch has been successfully rebased

@JesusPoderoso JesusPoderoso force-pushed the feature/logKind-stream branch from c81d2b4 to 3ffbf3e Compare February 8, 2024 11:16
@JesusPoderoso
Copy link
Copy Markdown
Contributor

@richiprosima please test this

@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Feb 8, 2024
@JesusPoderoso
Copy link
Copy Markdown
Contributor

@richiprosima please test mac please test linux

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Feb 9, 2024
@EduPonz EduPonz merged commit ec3cdcd into master Feb 10, 2024
@EduPonz EduPonz deleted the feature/logKind-stream branch February 10, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants