[20242] TypeLookup listeners implementation by adriancampo · Pull Request #4240 · eProsima/Fast-DDS

adriancampo · 2024-01-12T12:14:14Z

Description

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Changes are ABI compatible.
N/A Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
N/A Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupRequestListener.cpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.cpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.hpp

adriancampo · 2024-01-21T16:18:01Z

@richiprosima please test this

adriancampo · 2024-01-22T15:55:16Z

@richiprosima please test this

JLBuenoLopez

Partial review. TypeLookupManager and TypeLookupReplyListener classes pending to be reviewed.

include/fastdds/dds/domain/DomainParticipantListener.hpp

include/fastdds/dds/domain/qos/DomainParticipantQos.hpp

include/fastdds/rtps/attributes/RTPSParticipantAttributes.h

include/fastdds/rtps/builtin/discovery/endpoint/EDP.h

include/fastrtps/xmlparser/XMLParserCommon.h

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupRequestListener.cpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.hpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.cpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupManager.hpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupManager.cpp

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.hpp

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

…lbacks. Signed-off-by: adriancampo <adriancampo@eprosima.com>

Signed-off-by: adriancampo <adriancampo@eprosima.com>

…r_type_object(from TypeLookupManager). Signed-off-by: adriancampo <adriancampo@eprosima.com>

Signed-off-by: adriancampo <adriancampo@eprosima.com>

JLBuenoLopez

LGTM with green CI

JLBuenoLopez · 2024-04-05T06:53:19Z

@richiprosima please test_3 this

Signed-off-by: adriancampo <adriancampo@eprosima.com>

JLBuenoLopez

LGTM with green CI

JLBuenoLopez · 2024-04-05T09:51:59Z

@richiprosima please test_3 this

JLBuenoLopez · 2024-04-08T07:13:16Z

@richiprosima please test_3 this

JLBuenoLopez · 2024-04-09T07:37:14Z

The following Doxygen typo would be nice to fix in order for the documentation tests to pass:

Modifies instead of Mofifies.

Now we works successfully against OpenDDS 3.27 Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

JLBuenoLopez · 2024-04-09T10:07:54Z

@richiprosima please test_3 this

JLBuenoLopez

LGTM with green CI

JLBuenoLopez · 2024-04-09T10:28:54Z

Manual Documentation job: SUCCESS
Manual Discovery Server job: SUCCESS

fastdds.repos

test/unittest/dds/xtypes/type_representation/TypeObjectUtilsTests.cpp

Signed-off-by: Ricardo González <ricardo@richiware.dev>

JLBuenoLopez

LGTM with green CI

JLBuenoLopez · 2024-04-10T09:12:38Z

@richiprosima please test_3 this

adriancampo added the no-test Skip CI tests if PR marked with this label label Jan 12, 2024

adriancampo marked this pull request as ready for review January 12, 2024 12:16

adriancampo requested a review from JLBuenoLopez January 12, 2024 12:17

JLBuenoLopez suggested changes Jan 16, 2024

View reviewed changes

adriancampo force-pushed the feature/typelookup-listeners-implementation branch from f5f5abc to 52fc9f8 Compare January 19, 2024 18:33

adriancampo force-pushed the feature/typelookup-listeners-implementation branch 2 times, most recently from fde5978 to 29681bc Compare January 22, 2024 15:46

adriancampo changed the base branch from feature/xtypes1.3 to feature/type-object-integration January 22, 2024 15:47

adriancampo changed the base branch from feature/type-object-integration to feature/xtypes1.3 January 22, 2024 15:48

adriancampo changed the base branch from feature/xtypes1.3 to feature/type-object-integration January 22, 2024 15:49

adriancampo force-pushed the feature/typelookup-listeners-implementation branch from 9538ccd to 13eb216 Compare January 23, 2024 07:02

adriancampo changed the base branch from feature/type-object-integration to feature/xtypes1.3 January 23, 2024 07:02

adriancampo force-pushed the feature/typelookup-listeners-implementation branch from 13eb216 to 2e3caf5 Compare January 23, 2024 08:13

adriancampo changed the base branch from feature/xtypes1.3 to feature/type-object-integration January 23, 2024 08:14

adriancampo force-pushed the feature/typelookup-listeners-implementation branch 3 times, most recently from 38ebcb1 to dd105e0 Compare January 23, 2024 11:11

JLBuenoLopez force-pushed the feature/type-object-integration branch from ec6de74 to 1186bad Compare January 25, 2024 15:31

Base automatically changed from feature/type-object-integration to feature/xtypes1.3 January 29, 2024 06:56

adriancampo force-pushed the feature/typelookup-listeners-implementation branch 3 times, most recently from 27df183 to 918454a Compare February 1, 2024 20:05

JLBuenoLopez suggested changes Feb 6, 2024

View reviewed changes

JLBuenoLopez suggested changes Feb 12, 2024

View reviewed changes

JLBuenoLopez force-pushed the feature/xtypes1.3 branch from 7b4c6fb to bf49f7b Compare February 15, 2024 09:54

EduPonz added this to the v3.0.0 milestone Feb 21, 2024

EduPonz previously requested changes Feb 22, 2024

View reviewed changes

src/cpp/fastdds/builtin/type_lookup_service/TypeLookupReplyListener.hpp Outdated Show resolved Hide resolved

adriancampo force-pushed the feature/typelookup-listeners-implementation branch from de0d0e3 to 49cf957 Compare February 22, 2024 19:36

richiware and others added 13 commits April 5, 2024 07:47

Refs #20160. Remove old function

9556352

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #20160. Fix

343475d

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #20160: Fixes for TypeLookupManager destruction with pending cal…

129f7ea

…lbacks. Signed-off-by: adriancampo <adriancampo@eprosima.com>

Refs #20160: Changes for instance_names to use the full GUID.

45f94b5

Signed-off-by: adriancampo <adriancampo@eprosima.com>

Refs #20160: Applied suggestions. Removed overloaded discovery methods.

f3f8121

Signed-off-by: adriancampo <adriancampo@eprosima.com>

Refs #20160: Changes for xtypes doc.

e0040ed

Signed-off-by: adriancampo <adriancampo@eprosima.com>

Refs #20160: Fix for LOG macro. Remove consistency check from registe…

61ace27

…r_type_object(from TypeLookupManager). Signed-off-by: adriancampo <adriancampo@eprosima.com>

Refs #20160: Applied suggestions.

1bba30b

Signed-off-by: adriancampo <adriancampo@eprosima.com>

Refs #20160: Removed obsolete check.

f840f98

Signed-off-by: adriancampo <adriancampo@eprosima.com>

Refs #20160: Fixed DS tests and warnings.

0a9026a

Signed-off-by: adriancampo <adriancampo@eprosima.com>

Refs #20160: Fixes after rebase.

38c3df5

Signed-off-by: adriancampo <adriancampo@eprosima.com>

Refs #20160: Windows warning.

b45c43e

Signed-off-by: adriancampo <adriancampo@eprosima.com>

Refs #20160: Applied suggestions.

6d3bdd2

Signed-off-by: adriancampo <adriancampo@eprosima.com>

JLBuenoLopez approved these changes Apr 5, 2024

View reviewed changes

Refs #20160: Fixed tests.

27a861e

Signed-off-by: adriancampo <adriancampo@eprosima.com>

JLBuenoLopez approved these changes Apr 5, 2024

View reviewed changes

JLBuenoLopez mentioned this pull request Apr 9, 2024

[20242] Update discovery callbacks eProsima/Discovery-Server#75

Merged

richiware added 2 commits April 9, 2024 12:00

Refs #20242. Update unsupported_type_info tests.

b0e2e65

Now we works successfully against OpenDDS 3.27 Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

Refs #20242. Apply suggestion

feea1ec

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

JLBuenoLopez approved these changes Apr 9, 2024

View reviewed changes

JLBuenoLopez reviewed Apr 10, 2024

View reviewed changes

fastdds.repos Outdated Show resolved Hide resolved

test/unittest/dds/xtypes/type_representation/TypeObjectUtilsTests.cpp Show resolved Hide resolved

Refs #20242. Fix log thread being killed in windows on unit test

5ae348a

Signed-off-by: Ricardo González <ricardo@richiware.dev>

JLBuenoLopez approved these changes Apr 10, 2024

View reviewed changes

Conversation

adriancampo commented Jan 12, 2024 • edited by JLBuenoLopez Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

adriancampo commented Jan 21, 2024

Uh oh!

adriancampo commented Jan 22, 2024

Uh oh!

JLBuenoLopez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JLBuenoLopez left a comment

Choose a reason for hiding this comment

Uh oh!

JLBuenoLopez commented Apr 5, 2024

Uh oh!

JLBuenoLopez left a comment

Choose a reason for hiding this comment

Uh oh!

JLBuenoLopez commented Apr 5, 2024

Uh oh!

JLBuenoLopez commented Apr 8, 2024

Uh oh!

JLBuenoLopez commented Apr 9, 2024

Uh oh!

JLBuenoLopez commented Apr 9, 2024

Uh oh!

JLBuenoLopez left a comment

Choose a reason for hiding this comment

Uh oh!

JLBuenoLopez commented Apr 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JLBuenoLopez left a comment

Choose a reason for hiding this comment

Uh oh!

JLBuenoLopez commented Apr 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

adriancampo commented Jan 12, 2024 •

edited by JLBuenoLopez

Loading

JLBuenoLopez commented Apr 9, 2024 •

edited

Loading