Fix asymmetric whitelist matching [19035] (backport #3733)#3869
Closed
mergify[bot] wants to merge 1 commit into2.6.xfrom
Closed
Fix asymmetric whitelist matching [19035] (backport #3733)#3869mergify[bot] wants to merge 1 commit into2.6.xfrom
mergify[bot] wants to merge 1 commit into2.6.xfrom
Conversation
* Refs #18854: Asymmetric whitelist regression test Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #18854: Fix Windows build error Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #18854: Apply rev suggestions Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #19203: Add more test cases Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Refs #19203: Asymmetric whitelist matching fix: transform_remote_locators refactor Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> * Refs #19203: Tiny fixes Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #19203: Add warnings for non-localhost local address in initial peers and discovery server Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #19203: Bonus fix: TCPv6 + whitelist Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #19203: Avoid API/ABI break Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #19203: Fix TCP when no whitelist and initial peer != localhost Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19203: Improve some comments Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19203: Uncrustify Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19203: Fix missing include Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> * Refs #19203: Revert locator scope append in TCPChannelResourceBasic::connect Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * Refs #19203: Disable (almost) all IPv6 tests Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Signed-off-by: Juan López Fernández <juanlopez@eprosima.com> Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com> Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com> (cherry picked from commit c8ab860) # Conflicts: # include/fastdds/rtps/attributes/RTPSParticipantAttributes.h # include/fastdds/rtps/transport/TransportInterface.h # src/cpp/rtps/transport/TCPTransportInterface.cpp # test/mock/rtps/NetworkFactory/fastdds/rtps/network/NetworkFactory.h
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3733 done by Mergify.
Cherry-pick of c8ab860 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com