Skip to content

Fix asymmetric whitelist matching [19035] (backport #3733)#3869

Closed
mergify[bot] wants to merge 1 commit into2.6.xfrom
mergify/bp/2.6.x/pr-3733
Closed

Fix asymmetric whitelist matching [19035] (backport #3733)#3869
mergify[bot] wants to merge 1 commit into2.6.xfrom
mergify/bp/2.6.x/pr-3733

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Sep 21, 2023

This is an automatic backport of pull request #3733 done by Mergify.
Cherry-pick of c8ab860 has failed:

On branch mergify/bp/2.6.x/pr-3733
Your branch is up to date with 'origin/2.6.x'.

You are currently cherry-picking commit c8ab8602a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   include/fastdds/dds/core/policy/ParameterTypes.hpp
	modified:   include/fastdds/rtps/builtin/BuiltinProtocols.h
	new file:   include/fastdds/rtps/builtin/data/NetworkConfiguration.hpp
	modified:   include/fastdds/rtps/builtin/data/ParticipantProxyData.h
	modified:   include/fastdds/rtps/builtin/data/ReaderProxyData.h
	modified:   include/fastdds/rtps/builtin/data/WriterProxyData.h
	modified:   include/fastdds/rtps/common/Types.h
	modified:   include/fastdds/rtps/network/NetworkFactory.h
	modified:   include/fastdds/rtps/transport/ChainingTransport.h
	modified:   include/fastrtps/qos/ParameterTypes.h
	modified:   src/cpp/fastdds/core/policy/ParameterSerializer.hpp
	modified:   src/cpp/fastdds/domain/DomainParticipantImpl.cpp
	modified:   src/cpp/rtps/builtin/BuiltinProtocols.cpp
	modified:   src/cpp/rtps/builtin/data/ParticipantProxyData.cpp
	modified:   src/cpp/rtps/builtin/data/ReaderProxyData.cpp
	modified:   src/cpp/rtps/builtin/data/WriterProxyData.cpp
	modified:   src/cpp/rtps/builtin/discovery/participant/PDP.cpp
	modified:   src/cpp/rtps/builtin/discovery/participant/PDPSimple.cpp
	modified:   src/cpp/rtps/network/NetworkFactory.cpp
	modified:   src/cpp/rtps/participant/RTPSParticipantImpl.cpp
	modified:   src/cpp/rtps/transport/TCPAcceptor.cpp
	modified:   src/cpp/rtps/transport/TCPAcceptorBasic.cpp
	modified:   src/cpp/rtps/transport/TCPTransportInterface.h
	modified:   src/cpp/rtps/transport/TCPv6Transport.cpp
	modified:   src/cpp/rtps/transport/TCPv6Transport.h
	modified:   src/cpp/rtps/transport/UDPTransportInterface.cpp
	modified:   src/cpp/rtps/transport/UDPTransportInterface.h
	modified:   src/cpp/rtps/transport/shared_mem/SharedMemTransport.cpp
	modified:   src/cpp/rtps/transport/shared_mem/SharedMemTransport.h
	modified:   test/blackbox/common/BlackboxTestsNetworkConf.cpp
	modified:   test/blackbox/common/BlackboxTestsTransportTCP.cpp
	modified:   test/blackbox/common/BlackboxTestsTransportUDP.cpp
	modified:   test/unittest/rtps/network/mock/MockTransport.h
	modified:   test/unittest/transport/SharedMemTests.cpp
	modified:   test/unittest/transport/TCPv6Tests.cpp
	modified:   test/unittest/transport/UDPv6Tests.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   include/fastdds/rtps/attributes/RTPSParticipantAttributes.h
	both modified:   include/fastdds/rtps/transport/TransportInterface.h
	both modified:   src/cpp/rtps/transport/TCPTransportInterface.cpp
	both modified:   test/mock/rtps/NetworkFactory/fastdds/rtps/network/NetworkFactory.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Refs #18854: Asymmetric whitelist regression test

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #18854: Fix Windows build error

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #18854: Apply rev suggestions

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19203: Add more test cases

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

* Refs #19203: Asymmetric whitelist matching fix: transform_remote_locators refactor

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>

* Refs #19203: Tiny fixes

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

* Refs #19203: Add warnings for non-localhost local address in initial peers and discovery server

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

* Refs #19203: Bonus fix: TCPv6 + whitelist

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

* Refs #19203: Avoid API/ABI break

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

* Refs #19203: Fix TCP when no whitelist and initial peer != localhost

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19203: Improve some comments

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19203: Uncrustify

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19203: Fix missing include

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19203: Revert locator scope append in TCPChannelResourceBasic::connect

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

* Refs #19203: Disable (almost) all IPv6 tests

Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Co-authored-by: Eduardo Ponz <eduardoponz@eprosima.com>
(cherry picked from commit c8ab860)

# Conflicts:
#	include/fastdds/rtps/attributes/RTPSParticipantAttributes.h
#	include/fastdds/rtps/transport/TransportInterface.h
#	src/cpp/rtps/transport/TCPTransportInterface.cpp
#	test/mock/rtps/NetworkFactory/fastdds/rtps/network/NetworkFactory.h
@mergify mergify bot added the conflicts Backport PR wich git cherry pick failed label Sep 21, 2023
@mergify mergify bot mentioned this pull request Sep 21, 2023
11 tasks
@EduPonz EduPonz closed this Sep 21, 2023
@mergify mergify bot deleted the mergify/bp/2.6.x/pr-3733 branch September 21, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts Backport PR wich git cherry pick failed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants