Skip to content

Support new Fast-CDR v2.0.0 [19456]#3828

Merged
richiware merged 41 commits intomasterfrom
feature/xcdr
Sep 27, 2023
Merged

Support new Fast-CDR v2.0.0 [19456]#3828
richiware merged 41 commits intomasterfrom
feature/xcdr

Conversation

@richiware
Copy link
Copy Markdown
Member

@richiware richiware commented Sep 6, 2023 •
edited by JLBuenoLopez
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • [N/A] Changes are ABI compatible.
  • [NO] Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: Documentation about Fast-CDR v2.0.0 and new annotations [19458] Fast-DDS-docs#550
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Support new Fast-CDR v2.0.0 Support new Fast-CDR v2.0.0 [19456] Sep 6, 2023
@JLBuenoLopez JLBuenoLopez mentioned this pull request Sep 8, 2023
Merged
5 tasks
@richiware richiware mentioned this pull request Sep 8, 2023
Closed
6 tasks
@JLBuenoLopez JLBuenoLopez mentioned this pull request Sep 8, 2023
Closed
1 task
@EduPonz EduPonz mentioned this pull request Sep 9, 2023
Merged
@JLBuenoLopez JLBuenoLopez mentioned this pull request Sep 12, 2023
Closed
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 12, 2023

@richiprosima please test this

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 12, 2023

@richiprosima please test this

1 similar comment
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 12, 2023

@richiprosima please test this

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 12, 2023

@richiprosima please test linux

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 12, 2023

@richiprosima please test this

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 12, 2023

@richiprosima please test linux

MiguelCompany
MiguelCompany previously requested changes Sep 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top-level CMakeLists.txt should be updated to require fastcdr version above v2

@JLBuenoLopez JLBuenoLopez added this to the v2.12.0 milestone Sep 13, 2023
@JLBuenoLopez JLBuenoLopez mentioned this pull request Sep 13, 2023
Closed
13 tasks
JLBuenoLopez
JLBuenoLopez suggested changes Sep 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First partial review. Still a lot to review

@JLBuenoLopez JLBuenoLopez mentioned this pull request Sep 15, 2023
Closed
1 task
JLBuenoLopez
JLBuenoLopez reviewed Sep 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review until commit 4804ba68f8c913dec2fe3debada6944b34cabed4

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 18, 2023

The top-level CMakeLists.txt should be updated to require fastcdr version above v2

@MiguelCompany done in 006e71401

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 18, 2023

@richiprosima please test this

@JesusPoderoso JesusPoderoso mentioned this pull request Sep 18, 2023
Merged
7 tasks
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 19, 2023

@richiprosima please test this

JLBuenoLopez
JLBuenoLopez reviewed Sep 19, 2023
View reviewed changes
JLBuenoLopez
JLBuenoLopez reviewed Sep 19, 2023
View reviewed changes
@JesusPoderoso JesusPoderoso mentioned this pull request Sep 19, 2023
Merged
9 tasks
JLBuenoLopez
JLBuenoLopez reviewed Sep 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of comments regarding the TypeObject types...

Also, I think the versions.md should be updated with the API break in MEMBER_INVALID. I have updated the checklist including the N/A points. Check if you agree.

@JLBuenoLopez JLBuenoLopez added the ci-pending PR which CI is running label Sep 20, 2023
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 22, 2023

@richiprosima please test this

@richiware
Refs #18687. Remove Benchmark example
eb78332 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 25, 2023

@richiprosima please test this

1 similar comment
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 26, 2023

@richiprosima please test this

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 26, 2023

@richiprosima please test mac

3 similar comments
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 26, 2023

@richiprosima please test mac

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 26, 2023

@richiprosima please test mac

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 26, 2023

@richiprosima please test mac

@richiware
Refs #18687. Trying compile VS2017
042ac9a 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 26, 2023

@richiprosima please test this

3 similar comments
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 26, 2023

@richiprosima please test this

@EduPonz
Copy link
Copy Markdown

EduPonz commented Sep 26, 2023

@richiprosima please test this

@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 26, 2023

@richiprosima please test this

@richiware richiware force-pushed the feature/xcdr branch 3 times, most recently from 6849cee to 22a5ed4 Compare September 27, 2023 05:40
@richiware
Refs #18687. Fix warnings after upgrade clang
9c76dcc 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 27, 2023

@richiprosima please test this

JLBuenoLopez
JLBuenoLopez reviewed Sep 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the last minute changes! In order to improve the release process I think that we should take into account the following in the future:

  1. The infrastructure should be updated periodically. Maybe this could be done a month before the release date (but never in the same week).
  2. If a new tool has to be installed in such a short notice, it is important to look into the tool's dependencies and take into account that if some development tool is upgraded, the tool should not be installed until after the release.

JLBuenoLopez
JLBuenoLopez reviewed Sep 27, 2023
View reviewed changes
@JLBuenoLopez JLBuenoLopez removed the ci-pending PR which CI is running label Sep 27, 2023
JLBuenoLopez
JLBuenoLopez approved these changes Sep 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware merged commit 4204d41 into master Sep 27, 2023
@richiware richiware deleted the feature/xcdr branch September 27, 2023 09:16
@JLBuenoLopez JLBuenoLopez restored the feature/xcdr branch October 5, 2023 06:11
@JLBuenoLopez JLBuenoLopez mentioned this pull request Nov 13, 2023
Merged
7 tasks
@clalancette clalancette mentioned this pull request Jan 18, 2024
Merged
9 tasks
@rsanchez15 rsanchez15 deleted the feature/xcdr branch November 28, 2024 08:40
@coderabbitai coderabbitai bot mentioned this pull request Mar 21, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany left review comments

+1 more reviewer

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

first-to-merge

Projects

None yet

Milestone

v2.12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@richiware @JLBuenoLopez @EduPonz @MiguelCompany