[18966] SHM sending improvements (backport #3642)#3712
Merged
MiguelCompany merged 1 commit into2.9.xfrom Jul 17, 2023
Merged
Conversation
* Refs #18966. Refactor of try_push. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18966. Retry try_push after regenerating output port. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18966. Clean all output ports on every send. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18966. Clean output ports when they have no listeners. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18966: Applied suggestions Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #18966: Uncrustify Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #18966: Prevent port cleanup on Windows platforms Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> Co-authored-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit 2f80b06)
11 tasks
JesusPoderoso
approved these changes
Jul 13, 2023
Contributor
|
I think windows CI failed test is unrelated. Can you confirm @jsantiago-eProsima ? |
Contributor
|
Confirmed. That test is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3642 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com