[18763] Improve content filter expression parameters checks and verbosity. (backport #3565)#3593
Merged
MiguelCompany merged 1 commit into2.6.xfrom Aug 4, 2023
Merged
Conversation
10 tasks
Contributor
|
@jsantiago-eProsima can you take a look at these conflicts? |
…3565) * Refs #18763: Added max expression parameter test Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #18763: Fixed maximum parameter size checks when deserializing ContentFilteredTopics Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #18763: Added test for qos expression_parameter constraints Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #18763: Added check for expression_parameter constraints Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #18763: Added runtime modification to test Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #18763: Added check to set_expression_parameters Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #18763: Fixed signed/unsigned mismatch Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> * Refs #18763: Applied suggestions Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> --------- Signed-off-by: Javier Santiago <javiersantiago@eprosima.com> (cherry picked from commit 3073c64)
57ce327 to
5f48ee5
Compare
|
@richiprosima please test this |
MiguelCompany
approved these changes
Aug 3, 2023
Member
|
@richiprosima Please test mac |
|
@richiprosima please test mac |
|
@richiprosima please test windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3565 done by Mergify.
Cherry-pick of 3073c64 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com