Skip to content

Fixed TCP max msg size and TCPv4 Tests.#333

Merged
MiguelCompany merged 3 commits intorelease/1.7.0from
hotfix/tcp_max_msg_size
Nov 21, 2018
Merged

Fixed TCP max msg size and TCPv4 Tests.#333
MiguelCompany merged 3 commits intorelease/1.7.0from
hotfix/tcp_max_msg_size

Conversation

@LuisGP
Copy link
Copy Markdown
Contributor

@LuisGP LuisGP commented Nov 20, 2018

  • TCP internal buffers are now configured by maxMessageSize instead of socket sizes.
  • If TCP detects a message bigger than its buffer capacity, now drops all the expected bytes that don't fit instead of trying to read a TCP header again.
  • TCPv4 tests updated to use default message, and sockets buffer sizes.

@MiguelCompany
Copy link
Copy Markdown
Member

Please take the chance to also add default values to the in_use field of class ReceiverInUseCV

@MiguelCompany MiguelCompany added bug Issue to report a bug and removed enhancement labels Nov 20, 2018
@MiguelCompany MiguelCompany force-pushed the hotfix/tcp_max_msg_size branch from 3aeb1ea to c4b435e Compare November 20, 2018 11:27
@LuisGP LuisGP force-pushed the hotfix/tcp_max_msg_size branch from 3634f48 to 4a2aead Compare November 21, 2018 07:46
@MiguelCompany MiguelCompany merged commit 568f8a8 into release/1.7.0 Nov 21, 2018
@MiguelCompany MiguelCompany deleted the hotfix/tcp_max_msg_size branch November 21, 2018 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue to report a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants