[16910] Remove check 'Documentation builds and test pass locally' from pull request template by JesusPoderoso · Pull Request #3267 · eProsima/Fast-DDS

JesusPoderoso · 2023-02-02T14:17:54Z

…' from github PR template

Signed-off-by: JesusPoderoso jesuspoderoso@eprosima.com

This PR just removes the check from the template

Description

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Changes are ABI compatible.
N/A Changes are API compatible.
N/A Documentation builds and tests pass locally.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.

N/A Applicable backports have been included in the description.

Reviewer Checklist

Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

…' from github PR template Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

.github/actions/install-apt-packages-documentation/action.yml

.github/actions/install-apt-packages/action.yml

.github/workflows/documentation-tests.yaml

.github/actions/install-apt-packages-documentation/action.yml

.github/workflows/documentation-tests.yaml

.github/workflows/documentation/ci-documentation.repos

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Test new changes Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Test checkout action Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Test checkout action Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Test checkout action Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Test checkout action Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Test vcs import repos Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Remove fastrtps from repos file Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Remove fastrtps from repos file Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Remove fastrtps from repos file Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Remove fastrtps from repos file Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Remove fastrtps from repos file Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Remove fastrtps from repos file Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Remove fastrtps from repos file Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Fix repo name Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Fix repo name Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Fix repo name Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Fix repo name Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Test github action Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Test github action Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Refs #16910: Test github action Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Remove check 'Documentation builds and test pass locally…

e1ff2f9

…' from github PR template Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso added the skip-ci Automatically pass CI label Feb 2, 2023

Refs #16910: create new yaml for CI task (githubaction)

6d8dadb

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso marked this pull request as draft February 6, 2023 07:01

JesusPoderoso added 13 commits February 6, 2023 10:26

Refs #16910: Build proper test: testing in process

86618f7

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Force run CI action

25888ab

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Fix apt-install script

b45308c

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Fix apt-install script for documentation

b805ff6

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Remove doc8 from installation dependencie

c8ed27e

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Modify branch usage for docs

27b06c6

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Include apt update to avoid apt errors

751adeb

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Install vcs properly

78287ed

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Change branch management

dc9bc11

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Update branch management

0d109aa

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Source venv before building and testing

6019f09

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Rename variable for documentation branch

49290ce

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

Refs #16910: Uncomment skip-ci condition

eb0fc25

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso marked this pull request as ready for review February 13, 2023 13:15

JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed skip-ci Automatically pass CI labels Feb 13, 2023

Refs #16910: Add missing EOF

11c42bd

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

EduPonz suggested changes Feb 14, 2023

View reviewed changes

EduPonz added needs-review PR that is ready to be reviewed and removed ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Feb 15, 2023

JesusPoderoso force-pushed the hotfix/pull_request_template_update branch from c864fe7 to 5210cf2 Compare February 15, 2023 14:20

JesusPoderoso force-pushed the hotfix/pull_request_template_update branch 4 times, most recently from 334a62d to 5e3cd6f Compare February 15, 2023 15:45

JesusPoderoso force-pushed the hotfix/pull_request_template_update branch 20 times, most recently from 0265f7f to 04eb85f Compare February 16, 2023 10:06

Refs #16910: Apply revision suggestions

08cff1f

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

JesusPoderoso force-pushed the hotfix/pull_request_template_update branch from 04eb85f to 08cff1f Compare February 16, 2023 10:28

EduPonz approved these changes Feb 16, 2023

View reviewed changes

EduPonz merged commit 87b207d into master Feb 16, 2023

EduPonz deleted the hotfix/pull_request_template_update branch February 16, 2023 13:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16910] Remove check 'Documentation builds and test pass locally' from pull request template#3267

[16910] Remove check 'Documentation builds and test pass locally' from pull request template#3267
EduPonz merged 18 commits intomasterfrom
hotfix/pull_request_template_update

JesusPoderoso commented Feb 2, 2023 •

edited by EduPonz

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

JesusPoderoso commented Feb 2, 2023 • edited by EduPonz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JesusPoderoso commented Feb 2, 2023 •

edited by EduPonz

Loading