Skip to content

[16802] Branch out 2.10.x#3231

Merged
MiguelCompany merged 2 commits intomasterfrom
release/2.10.x
Jan 19, 2023
Merged

[16802] Branch out 2.10.x#3231
MiguelCompany merged 2 commits intomasterfrom
release/2.10.x

Conversation

@EduPonz
Copy link
Copy Markdown

@EduPonz EduPonz commented Jan 19, 2023

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Fast DDS test suite has been run locally.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • Check contributor checklist is correct.
  • N/A Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
@EduPonz EduPonz added the skip-ci Automatically pass CI label Jan 19, 2023
@EduPonz EduPonz added this to the v2.9.1 milestone Jan 19, 2023
@EduPonz EduPonz requested a review from MiguelCompany January 19, 2023 06:29
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should hold till the bloom release of 2.9.1 is done.

@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. first-to-merge labels Jan 19, 2023
@MiguelCompany MiguelCompany merged commit cc50613 into master Jan 19, 2023
@MiguelCompany MiguelCompany deleted the release/2.10.x branch January 19, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-to-merge ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. skip-ci Automatically pass CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants