Skip to content

Improve doxygen documentation for ResourceLimitsQos [16814]#3228

Merged
MiguelCompany merged 1 commit intomasterfrom
feature/improve-doxygen
Mar 17, 2023
Merged

Improve doxygen documentation for ResourceLimitsQos [16814]#3228
MiguelCompany merged 1 commit intomasterfrom
feature/improve-doxygen

Conversation

@richiware
Copy link
Copy Markdown
Member

@richiware richiware commented Jan 18, 2023

Description

This PR specifies the meaning of value 0 in ResourceLimitsQos attributes.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Fast DDS test suite has been run locally.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Improve doxygen documentation for ResourceLimitsQos Improve doxygen documentation for ResourceLimitsQos [16814] Jan 18, 2023
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Jan 18, 2023
@MiguelCompany
Copy link
Copy Markdown
Member

@richiprosima Please test this

@JLBuenoLopez JLBuenoLopez added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Mar 16, 2023
@JLBuenoLopez JLBuenoLopez added this to the v2.10.0 milestone Mar 16, 2023
@MiguelCompany MiguelCompany merged commit 89cb7d0 into master Mar 17, 2023
@MiguelCompany MiguelCompany deleted the feature/improve-doxygen branch March 17, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants