Skip to content

Revert "Fix total_unread_ consistent with reader's history after get_…#3221

Merged
MiguelCompany merged 1 commit intomasterfrom
fujitatomoya/20230117-rmw_fastrtps-issue-659
Jan 17, 2023
Merged

Revert "Fix total_unread_ consistent with reader's history after get_…#3221
MiguelCompany merged 1 commit intomasterfrom
fujitatomoya/20230117-rmw_fastrtps-issue-659

Conversation

@fujitatomoya
Copy link
Copy Markdown
Contributor

@fujitatomoya fujitatomoya commented Jan 17, 2023

…first_untaken_info (#3203)"

This reverts commit de5cd9c.

Signed-off-by: Tomoya Fujita Tomoya.Fujita@sony.com

Description

see ros2/rmw_fastrtps#659

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@fujitatomoya
Revert "Fix total_unread_ consistent with reader's history after get_…
28072ba 
…first_untaken_info (#3203)"

This reverts commit de5cd9c.

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya mentioned this pull request Jan 17, 2023
Closed
fujitatomoya
fujitatomoya commented Jan 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be reverted since ros2/rmw_fastrtps#659.

we need to re-commit #3203 as complete fix.

@fujitatomoya
Copy link
Copy Markdown
Contributor Author

fujitatomoya commented Jan 17, 2023

@MiguelCompany @richiware friendly ping, this is breaking ROS 2 CI. as @clalancette mentioned, if this cannot be merge in today, we will pin the commit hash ros2/rmw_fastrtps#659 (comment)

@MiguelCompany
Copy link
Copy Markdown
Member

MiguelCompany commented Jan 17, 2023

We will rework #3203 tomorrow with an improved solution

@MiguelCompany MiguelCompany merged commit db9f398 into master Jan 17, 2023
@MiguelCompany MiguelCompany deleted the fujitatomoya/20230117-rmw_fastrtps-issue-659 branch January 17, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@Mario-DL Mario-DL Awaiting requested review from Mario-DL

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fujitatomoya @MiguelCompany