Skip to content

Improved Instance Handle performance#3204

Draft
jsan-rt wants to merge 2 commits intomasterfrom
feature/instancehandle_collections
Draft

Improved Instance Handle performance#3204
jsan-rt wants to merge 2 commits intomasterfrom
feature/instancehandle_collections

Conversation

@jsan-rt
Copy link
Copy Markdown
Contributor

@jsan-rt jsan-rt commented Jan 11, 2023

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jsan-rt
Added hash function to InstanceHandle. Turned InstanceCollections int…
d71355a 
…o an unordered_map

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@jsan-rt
Improved comparison operators
0348409 
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
@JLBuenoLopez
Copy link
Copy Markdown
Contributor

JLBuenoLopez commented Mar 16, 2023

@jsantiago-eProsima What is the status of this Draft? Can it be closed? Do we need to keep working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsan-rt @JLBuenoLopez