[16192] Fix notification lost (backport #3194)#3198
Merged
MiguelCompany merged 2 commits into2.8.xfrom Jan 11, 2023
Merged
Conversation
* fix notification lost Signed-off-by: Chen Lihui <lihui.chen@sony.com> * add a regression test Signed-off-by: Chen Lihui <lihui.chen@sony.com> * rename a variable name and update comments Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix uncrustify issue Signed-off-by: Chen Lihui <lihui.chen@sony.com> * make the regression test better Signed-off-by: Chen Lihui <lihui.chen@sony.com> * fix uncrustify Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Refs #16192. Fix deadlock on WaitSetImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Fix deadlock on ReadConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Use mutex instead of atomic. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #16192. Fix deadlock when constructing ReadConditionImpl. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Co-authored-by: Chen Lihui <lihui.chen@sony.com> (cherry picked from commit df2857a) # Conflicts: # src/cpp/fastdds/subscriber/ReadConditionImpl.hpp
11 tasks
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Member
|
@richiprosima Please test this |
MiguelCompany
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3194 done by Mergify.
Cherry-pick of df2857a has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com