Skip to content

Revert "Fix waitset notification (#3087)"#3193

Merged
MiguelCompany merged 1 commit intomasterfrom
hotfix/revert-3087
Jan 9, 2023
Merged

Revert "Fix waitset notification (#3087)"#3193
MiguelCompany merged 1 commit intomasterfrom
hotfix/revert-3087

Conversation

@MiguelCompany
Copy link
Copy Markdown
Member

This reverts commit a9e49cd.

Description

Reverting #3087 since solution is suboptimal. Will open new PR with better solution.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A Documentation builds and tests pass locally.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Jan 9, 2023
@MiguelCompany MiguelCompany mentioned this pull request Jan 9, 2023
13 tasks
@MiguelCompany MiguelCompany merged commit e4c5354 into master Jan 9, 2023
@MiguelCompany MiguelCompany deleted the hotfix/revert-3087 branch January 9, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-ci Automatically pass CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants