Skip to content

Add ASAN CI tests for fastdds and Discovery Server [16116]#3084

Merged
EduPonz merged 5 commits intomasterfrom
ci/asan
Nov 15, 2022
Merged

Add ASAN CI tests for fastdds and Discovery Server [16116]#3084
EduPonz merged 5 commits intomasterfrom
ci/asan

Conversation

@jparisu
Copy link
Copy Markdown
Contributor

@jparisu jparisu commented Nov 11, 2022 •
edited
Loading

Signed-off-by: jparisu javierparis@eprosima.com

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Add ASAN CI tests for fastdds and Discovery Server
56b5e61 
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu changed the title Add ASAN CI tests for fastdds and Discovery Server Add ASAN CI tests for fastdds and Discovery Server [16116] Nov 11, 2022
This was referenced Nov 11, 2022
Closed
Closed
jparisu added 4 commits November 11, 2022 12:48
add py dependencies
64c4183 
Signed-off-by: jparisu <javierparis@eprosima.com>
adjust timeout and make report ASAN fail only if asan errors
c9c10c5 
Signed-off-by: jparisu <javierparis@eprosima.com>
fix typos in workflow
02488ff 
Signed-off-by: jparisu <javierparis@eprosima.com>
new fix typos
f74043e 
Signed-off-by: jparisu <javierparis@eprosima.com>
rsanchez15
rsanchez15 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@rsanchez15 rsanchez15 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, I'd upload also de .snapshot~ files from build/Discovery-Server/test/ so we can check why the tests are failing. This can be done in another PR so we can merge this one right now.

@EduPonz EduPonz added the skip-ci Automatically pass CI label Nov 15, 2022
@EduPonz EduPonz merged commit f0888e2 into master Nov 15, 2022
@EduPonz EduPonz deleted the ci/asan branch November 15, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsanchez15 rsanchez15 rsanchez15 approved these changes

Assignees

No one assigned

Labels

skip-ci Automatically pass CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jparisu @rsanchez15 @EduPonz