Skip to content

[15014] Fix for not logError in filPublisherAttributes call#2973

Merged
MiguelCompany merged 2 commits intomasterfrom
hotfix/fillpubattrs_call_fromenable
Sep 23, 2022
Merged

[15014] Fix for not logError in filPublisherAttributes call#2973
MiguelCompany merged 2 commits intomasterfrom
hotfix/fillpubattrs_call_fromenable

Conversation

@MRicoIE2CS
Copy link
Copy Markdown
Contributor

Signed-off-by: Mikel Rico mikelrico@eprosima.com

Fix for not getting logError in filPublisherAttributes call, when using statistics with EV or property policy fastdds.statistics

Description

logErrors were printed when using EV for Statistics topics.
This comes from the PR https://github.com/eProsima/Fast-DDS/pull/2927/files#
The solution is to write the parameter for not printing those messages in those calls.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • [N/A] Documentation builds and tests pass locally.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • [N/A] New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 183 should also be modified

Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
@MiguelCompany
Copy link
Copy Markdown
Member

@richiprosima Please test this

Copy link
Copy Markdown
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit 7bc586f into master Sep 23, 2022
@MiguelCompany MiguelCompany deleted the hotfix/fillpubattrs_call_fromenable branch September 23, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants