[15014] Fix for not logError in filPublisherAttributes call#2973
Merged
MiguelCompany merged 2 commits intomasterfrom Sep 23, 2022
Merged
[15014] Fix for not logError in filPublisherAttributes call#2973MiguelCompany merged 2 commits intomasterfrom
MiguelCompany merged 2 commits intomasterfrom
Conversation
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
MiguelCompany
requested changes
Sep 23, 2022
Member
MiguelCompany
left a comment
There was a problem hiding this comment.
Line 183 should also be modified
Signed-off-by: Mikel Rico <mikelrico@eprosima.com>
Member
|
@richiprosima Please test this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikel Rico mikelrico@eprosima.com
Fix for not getting logError in
filPublisherAttributescall, when using statistics with EV or property policyfastdds.statisticsDescription
logErrorswere printed when using EV for Statistics topics.This comes from the PR https://github.com/eProsima/Fast-DDS/pull/2927/files#
The solution is to write the parameter for not printing those messages in those calls.
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist