Skip to content

Fix missing depend on python3#2958

Closed
giusebar wants to merge 3 commits intoeProsima:masterfrom
giusebar:giusebar-patch-1
Closed

Fix missing depend on python3#2958
giusebar wants to merge 3 commits intoeProsima:masterfrom
giusebar:giusebar-patch-1

Conversation

@giusebar
Copy link
Copy Markdown
Contributor

Description

A few test and tools depend on python3 interpreter. This is only installed in the github action yml, but it is currently missing from the package.xml.

This issue was spotted in the 2.1.x branch (ROS foxy distribution), hence it will require backporting.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • [] New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@giusebar giusebar closed this Sep 20, 2022
@giusebar giusebar deleted the giusebar-patch-1 branch September 20, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant