Skip to content

Update script for generating idl files [15483]#2940

Merged
richiware merged 3 commits intomasterfrom
bugfix/idl-script
Sep 16, 2022
Merged

Update script for generating idl files [15483]#2940
richiware merged 3 commits intomasterfrom
bugfix/idl-script

Conversation

@richiware
Copy link
Copy Markdown
Member

@richiware richiware commented Sep 1, 2022

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #15294. Fix
27ea878 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #15294. Fix unit test
2f30c16 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware changed the title Update script for generating idl files Update script for generating idl files [15483] Sep 1, 2022
JLBuenoLopez
JLBuenoLopez suggested changes Sep 2, 2022
View reviewed changes
@richiware
Refs #15483. Apply suggestions
67797b9 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
JLBuenoLopez
JLBuenoLopez approved these changes Sep 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLBuenoLopez JLBuenoLopez added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Sep 15, 2022
@richiware
Copy link
Copy Markdown
Member Author

richiware commented Sep 16, 2022

Insert a new bash script. Not need of testing.

@richiware richiware merged commit 08ffe7c into master Sep 16, 2022
@richiware richiware deleted the bugfix/idl-script branch September 16, 2022 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@richiware @JLBuenoLopez