Refs #3468 Added methods to ease dds-security adaptation.#269
Merged
MiguelCompany merged 3 commits intodevelopfrom Oct 16, 2018
Merged
Refs #3468 Added methods to ease dds-security adaptation.#269MiguelCompany merged 3 commits intodevelopfrom
MiguelCompany merged 3 commits intodevelopfrom
Conversation
MiguelCompany
requested changes
Oct 8, 2018
Member
MiguelCompany
left a comment
There was a problem hiding this comment.
Apart from the comments below, could you take the chance to change tabs into spaces on the whole file?
Member
There was a problem hiding this comment.
This will use 32 bit arithmetic. Please use ULL literals to all constants to force 64-bit arithmetic
Member
There was a problem hiding this comment.
I think this can produce a warning on some systems, as the result of the calculation is a long double. So I think a cast is required here.
Contributor
Author
|
Done, pong! |
MiguelCompany
previously approved these changes
Oct 9, 2018
358fbba to
18d2f8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some methods to easy Time_t (and Duration_t) class management: