Receive const pointers on delete_xxx methods [10764]#1807
Merged
MiguelCompany merged 4 commits intomasterfrom Mar 8, 2021
Merged
Receive const pointers on delete_xxx methods [10764]#1807MiguelCompany merged 4 commits intomasterfrom
MiguelCompany merged 4 commits intomasterfrom
Conversation
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
5 tasks
JLBuenoLopez
approved these changes
Mar 8, 2021
Contributor
JLBuenoLopez
left a comment
There was a problem hiding this comment.
LGTM.
CI results seem to be already known flaky tests. Discovery server test #33 is the first time that fails and I am unable to reproduce it locally, so it seems to also be flaky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.